From: Andi Kleen <ak@suse.de>
To: blaisorblade@yahoo.it
Cc: torvalds@osdl.org, akpm@osdl.org, linux-kernel@vger.kernel.org,
ak@suse.de
Subject: Re: [patch 2/3] x86_64: remove duplicated sys_time64
Date: Thu, 31 Mar 2005 12:38:34 +0200 [thread overview]
Message-ID: <20050331103834.GC1623@wotan.suse.de> (raw)
In-Reply-To: <20050330173216.426CFEFECF@zion>
On Wed, Mar 30, 2005 at 07:32:16PM +0200, blaisorblade@yahoo.it wrote:
>
> CC: Andi Kleen <ak@suse.de>
>
> Keeping this function does not makes sense because it's a copied (and buggy)
> copy of sys_time. The only difference is that now.tv_sec (which is a time_t,
> i.e. a 64-bit long) is copied (and truncated) into a int (32-bit).
>
> The prototype is the same (they both take a long __user *), so let's drop this
> and redirect it to sys_time (and make sure it exists by defining
> __ARCH_WANT_SYS_TIME).
>
> Only disadvantage is that the sys_stime definition is also compiled (may be
> fixed if needed by adding a separate __ARCH_WANT_SYS_STIME macro, and defining
> it for all arch's defining __ARCH_WANT_SYS_TIME except x86_64).
>
> Not compile-tested, sorry.
Nack. The generic sys_time still writes to int, not long.
That is why x86-64 has a private one. Please keep that.
-Andi
next prev parent reply other threads:[~2005-03-31 10:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-30 17:32 [patch 2/3] x86_64: remove duplicated sys_time64 blaisorblade
2005-03-31 10:38 ` Andi Kleen [this message]
2005-03-31 11:10 ` Stephen Rothwell
2005-03-31 11:12 ` Andi Kleen
2005-03-31 11:25 ` Stephen Rothwell
2005-03-31 11:36 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050331103834.GC1623@wotan.suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=blaisorblade@yahoo.it \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.