All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>,
	Scott_Kilau@digi.com, wendyx@us.ltcfwd.linux.ibm.com
Cc: linux-kernel@vger.kernel.org
Subject: [2.6 patch] let SERIAL_JSM depend on PCI
Date: Fri, 1 Apr 2005 00:23:25 +0200	[thread overview]
Message-ID: <20050331222325.GK3185@stusta.de> (raw)
In-Reply-To: <20050331022554.735a1118.akpm@osdl.org>

Compiling SERIAL_JSM with PCI=n results in the following compile error:

<--  snip  -->

...
  LD      .tmp_vmlinux1
drivers/built-in.o(.text+0x132800): In function `jsm_remove_one':
: undefined reference to `pci_release_regions'
make: *** [.tmp_vmlinux1] Error 1

<--  snip  -->


Since this driver is only for PCi boards, this patch adds a dependency 
on PCI.

Since I noticed that the Kconfig entry used whitespace instead of tabs, 
I corrected this, too.

Signed-off-by: Adrian Bunk <bunk@fs.tum.de>

--- linux-2.6.12-rc1-mm4-full/drivers/serial/Kconfig.old	2005-04-01 00:16:07.000000000 +0200
+++ linux-2.6.12-rc1-mm4-full/drivers/serial/Kconfig	2005-04-01 00:19:15.000000000 +0200
@@ -828,18 +828,19 @@
 	  a console on a serial port, say Y.  Otherwise, say N.
 
 config SERIAL_JSM
-        tristate "Digi International NEO PCI Support"
-        select SERIAL_CORE
-        help
-          This is a driver for Digi International's Neo series
-          of cards which provide multiple serial ports. You would need
-          something like this to connect more than two modems to your Linux
-          box, for instance in order to become a dial-in server. This driver
-          supports PCI boards only.
-          If you have a card like this, say Y here and read the file
-          <file:Documentation/jsm.txt>.
+	tristate "Digi International NEO PCI Support"
+	depends on PCI
+	select SERIAL_CORE
+	help
+	  This is a driver for Digi International's Neo series
+	  of cards which provide multiple serial ports. You would need
+	  something like this to connect more than two modems to your Linux
+	  box, for instance in order to become a dial-in server. This driver
+	  supports PCI boards only.
+	  If you have a card like this, say Y here and read the file
+	  <file:Documentation/jsm.txt>.
 
-          To compile this driver as a module, choose M here: the
-          module will be called jsm.
+	  To compile this driver as a module, choose M here: the
+	  module will be called jsm.
 
 endmenu

  parent reply	other threads:[~2005-03-31 22:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-31 10:25 2.6.12-rc1-mm4 Andrew Morton
2005-03-31 10:52 ` 2.6.12-rc1-mm4 Coywolf Qi Hunt
2005-03-31 22:23 ` Adrian Bunk [this message]
2005-04-01  7:24 ` 2.6.12-rc1-mm4 Jan Dittmer
2005-04-02 13:38 ` 2.6.12-rc1-mm4: oops in sysfs/symlink.c Manuel Lauss
2005-04-04 10:54 ` 2.6.12-rc1-mm4 Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050331222325.GK3185@stusta.de \
    --to=bunk@stusta.de \
    --cc=Scott_Kilau@digi.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wendyx@us.ltcfwd.linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.