From: "David S. Miller" <davem@davemloft.net>
To: James Bottomley <James.Bottomley@steeleye.com>
Cc: linux-arch@vger.kernel.org
Subject: Re: Consolidation of asm/unaligned.h
Date: Sun, 3 Apr 2005 21:02:01 -0700 [thread overview]
Message-ID: <20050403210201.6ecd41aa.davem@davemloft.net> (raw)
In-Reply-To: <1112586161.7087.3.camel@mulgrave>
On Sun, 03 Apr 2005 22:42:41 -0500
James Bottomley <James.Bottomley@SteelEye.com> wrote:
> I just got around to checking this on parisc, and I'm afraid we have a
> toolchain cockup: Our gcc can't optimise the sizeof() if the user is an
> inline function. It can, however if the functions are made #defines
> instead.
>
> Would the attached be OK with everyone? It works fine for us.
Please explain what you mean by "optimize"?
If you are saying what I think you're saying (that gcc always
emits the entire switch statement, not just the constant case
we need) I bet it has to do with inlining or switch statement
heuristics.
In any event, I'd like to be better informed, because this means
you're getting terrible code in a lot of places as this is
a common technique in the kernel header files.
I also don't want to make these macros, since if we do so we lose
the type checking and we also get into the world of CPP macro arg
multiple-evaluation crazyness.
next prev parent reply other threads:[~2005-04-04 4:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-17 18:47 Consolidation of asm/unaligned.h David S. Miller
2005-03-17 21:33 ` Russell King
2005-03-17 21:51 ` David S. Miller
2005-03-17 21:57 ` Geert Uytterhoeven
2005-03-17 22:03 ` David S. Miller
2005-03-18 0:20 ` Richard Henderson
2005-03-18 4:13 ` David S. Miller
2005-03-17 23:27 ` Ralf Baechle
2005-03-18 0:25 ` David Woodhouse
2005-04-04 3:42 ` James Bottomley
2005-04-04 4:02 ` David S. Miller [this message]
2005-04-04 4:15 ` James Bottomley
2005-04-04 6:11 ` David S. Miller
2005-04-04 11:34 ` Matthew Wilcox
2005-04-04 10:47 ` Ralf Baechle
2005-04-05 14:10 ` James Bottomley
2005-04-05 14:15 ` Ralf Baechle
2005-04-05 15:02 ` Matthew Wilcox
2005-04-05 15:11 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050403210201.6ecd41aa.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=James.Bottomley@steeleye.com \
--cc=linux-arch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.