From: Pavel Machek <pavel@ucw.cz>
To: David Brownell <david-b@pacbell.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Re(2): fix u32 vs. pm message t in usb
Date: Mon, 4 Apr 2005 00:57:29 +0200 [thread overview]
Message-ID: <20050403225729.GD13466@elf.ucw.cz> (raw)
In-Reply-To: <200504031301.02179.david-b@pacbell.net>
Hi!
> > Okay, you obviously have easy access to usb development trees...
> > Do you think you could just take this patch as a basis and fix
> > remaining u32 vs pm-message-t in usb? --p
>
> Fixing the "sparse -Wbitwise" messages, and addressing some other
> behavior changes/bugs that crept in, was the idea. That's already
> done, but _without_ taking this as a basis (or breaking the sysfs
> support etc).
Okay, if you fixed -Wbitwise, it should be all fixed...
> The patches I sent fix everything I had time to test (just a subset
> of the dozens of cases previously tested, probably covering the main
> stuff that got broken) except the non-PCI platform_bus drivers where
> pm_message_t has discarded essential functionality. (Notably, info
> about whether device clocks and/or power must be turned off.)
At what places is essential functionality lost? I thought that u32
state is pretty much always 3 ;-). Is there platform where it is not
the case?
Could you push also trivial bits that you could not test? I'd like to
get rid of all "u32 state"s...
> p.s. PCI-express patches don't belong with USB patches. :)
Oops, sorry. Same maintainer, though ;-).
Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
prev parent reply other threads:[~2005-04-03 22:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20050403193216.961D5194084@smtp.etmail.cz>
2005-04-03 20:01 ` Re(2): fix u32 vs. pm message t in usb David Brownell
2005-04-03 22:57 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050403225729.GD13466@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.