Re: [PATCH pom-ng] H.225 parser for h323-conntrack-nat

[Max Kellermann <max@duempel.org>]

Hi all,

back from vacation now.

On 2005/04/04 10:07, Jozsef Kadlecsik <kadlec@blackhole.kfki.hu> wrote:
> > Jozsef: what do you think of that patch? h.323 helper is your code,
> > after all.
> 
> Max does the right thing. And as he completes the helper with the H.245
> parser, we could finally consider to push the helper into the
> kernel. :-)

Jozsef, thanks for confirming my patches. The H.225 parser works for
the clients I tested, but needs more work, because it *may* break
other clients (no ASN.1-PER parser, just q'n'd).

I have already written a lean H.245 parser which is working for me. It
aims to parse the ASN.1-PER correctly, but it has grown more complex
than I had expected. I will release it after I have spent more time on
cleanup, review and testing.

Security is my goal #1; what we need least is a remote kernel hole
(other ASN.1 parsers had holes in the past). This is the most complex
conntrack helper until now. It has to undergo much more review before
we can recommend it for the mainstream kernel.

Once the H.245 parser is finished, the H.225 parser will be rewritten
using my low-level ASN.1-PER parser library.

Max