On 01/04/05 14:20 +0200, Christophe Lucas wrote:
> Description:
> String form : char foo[] = "blah" is better than char *foo = "blah"
> 
> Signed-off-by: Christophe Lucas <clucas@rotomalug.org>

> diff -urpN -X dontdiff a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c
> --- a/drivers/char/agp/intel-agp.c	2005-03-18 02:34:12.000000000 +0100
> +++ b/drivers/char/agp/intel-agp.c	2005-04-01 12:08:36.751735144 +0200
> @@ -1532,7 +1532,7 @@ static int __devinit agp_intel_probe(str
>  				     const struct pci_device_id *ent)
>  {
>  	struct agp_bridge_data *bridge;
> -	char *name = "(unknown)";
> +	char name[] = "(unknown)";

A few lines below there's a
	name = "440LX";
... so i don't think this will even compile.
Same goes for next, acpi patch.


	Domen