From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dave Jones <davej@redhat.com>
Subject: Re: [PATCH] incorrect memset usage.
Date: Tue, 5 Apr 2005 12:19:23 -0400
Message-ID: <20050405161923.GA8006@redhat.com>
References: <A95E2296287EAD4EB592B5DEEFCE0E9D1E3A2D@liverpoolst.ad.cl.cam.ac.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <A95E2296287EAD4EB592B5DEEFCE0E9D1E3A2D@liverpoolst.ad.cl.cam.ac.uk>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Pratt <m+Ian.Pratt@cl.cam.ac.uk>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On Tue, Apr 05, 2005 at 07:58:52AM +0100, Ian Pratt wrote:
 > 
 > I think these have already been applied, no?
 > Thanks,
 > Ian 

Only in the unstable tree.
This one..

 > > --- xen-2.0.bk/tools/libxutil/sys_net.c~	2005-03-31 
 > > 01:11:27.852264603 -0500
 > > +++ xen-2.0.bk/tools/libxutil/sys_net.c	2005-03-31 
 > > 01:11:39.320054735 -0500
 > > @@ -310,7 +310,7 @@ char *mac_ntoa(const unsigned char *mac)
 > >      static char buf[MAC_LENGTH + 1];
 > >      int buf_n = sizeof(buf);
 > >  
 > > -    memset(buf, buf_n, 0);
 > > +    memset(buf, 0, buf_n);
 > >      snprintf(buf, buf_n, "%02x:%02x:%02x:%02x:%02x:%02x",
 > >               mac[0], mac[1], mac[2],
 > >               mac[3], mac[4], mac[5]);
 > > 

Still isn't it seems..

(12:16:09:davej@mesh:xen-2.0.bk)$ bk pull
Pull bk://xen.bkbits.net/xen-2.0.bk
  -> file://home/davej/xen-2.0.bk
Nothing to pull.


		Dave