From: Chris Mason <mason@suse.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Nikita Danilov <nikita@clusterfs.com>,
Andrea@suse.de, linux-mm@kvack.org
Subject: Re: "orphaned pagecache memleak fix" question.
Date: Wed, 6 Apr 2005 17:12:46 -0400 [thread overview]
Message-ID: <200504061712.47244.mason@suse.com> (raw)
In-Reply-To: <20050406005804.0045faf9.akpm@osdl.org>
On Wednesday 06 April 2005 03:58, Andrew Morton wrote:
> > - wouldn't it be simpler to unconditionally remove page from LRU in
> > ->invalidatepage()?
>
> I guess that's an option, yes. If the fs cannot successfully invalidate
> the page then it can either block (as described above) or remove the page
> from the LRU. The fs then wholly owns the page.
>
> I think it would be better to make ->invalidatepage always succeed though.
> The situation is probably rare.
In data=journal it isn't rare at all. Dropping the page from the lru would be
the best solution I think.
-chris
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2005-04-06 21:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-05 16:02 "orphaned pagecache memleak fix" question Nikita Danilov
2005-04-06 7:58 ` Andrew Morton
2005-04-06 12:06 ` Nikita Danilov
2005-04-06 19:27 ` Andrew Morton
2005-04-06 21:07 ` Nikita Danilov
2005-04-06 21:34 ` Andrew Morton
2005-04-06 21:12 ` Chris Mason [this message]
2005-04-06 21:30 ` Andrew Morton
2005-04-06 21:50 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200504061712.47244.mason@suse.com \
--to=mason@suse.com \
--cc=Andrea@suse.de \
--cc=akpm@osdl.org \
--cc=linux-mm@kvack.org \
--cc=nikita@clusterfs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.