From: Christoph Hellwig <hch@infradead.org>
To: Jeremy Higdon <jeremy@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Hannes Reinecke <hare@suse.de>,
Linux Kernel <linux-kernel@vger.kernel.org>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] Use proper seq_file api for /proc/scsi/scsi
Date: Fri, 8 Apr 2005 08:56:43 +0100 [thread overview]
Message-ID: <20050408075643.GA5514@infradead.org> (raw)
In-Reply-To: <20050408072345.GA1018765@sgi.com>
On Fri, Apr 08, 2005 at 12:23:46AM -0700, Jeremy Higdon wrote:
> > It works for those setups that already worked with 2.4.x, aka only a few
> > luns.
>
> Even if it's deprecated, wouldn't it be good to fix it as long as
> it's there, unless it hurts something else? Or at least fix the
> out of memory error, even if it doesn't display all the luns?
What other error would you return? I don't particularly care what exact
error code to return, but putting in Hannes patch would be a bad idea because
it
a) poke deep into driver model internals, and we absolutely want to avoid
that
b) sets a bad precedence that we'll continue adding features to deprecated
interface and thus encurage people to contiue using it. Note that
/proc/scsi/* has been deprecated since mid-2.5.x.
next prev parent reply other threads:[~2005-04-08 7:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-07 9:46 [PATCH] Use proper seq_file api for /proc/scsi/scsi Hannes Reinecke
2005-04-07 10:31 ` Christoph Hellwig
2005-04-07 11:21 ` Hannes Reinecke
2005-04-07 11:21 ` Hannes Reinecke
2005-04-07 11:24 ` Christoph Hellwig
2005-04-08 7:23 ` Jeremy Higdon
2005-04-08 7:56 ` Christoph Hellwig [this message]
2005-04-08 7:59 ` Arjan van de Ven
2005-04-08 8:10 ` Jeremy Higdon
2005-04-08 14:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050408075643.GA5514@infradead.org \
--to=hch@infradead.org \
--cc=hare@suse.de \
--cc=jeremy@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.