From: Ingo Molnar <mingo@elte.hu>
To: Daniel Walker <dwalker@mvista.com>
Cc: Lee Revell <rlrevell@joe-job.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Trond Myklebust <trond.myklebust@fys.uio.no>
Subject: Re: 'BUG: scheduling with irqs disabled' when umounting NFS volume
Date: Sat, 9 Apr 2005 06:44:49 +0200 [thread overview]
Message-ID: <20050409044449.GA2857@elte.hu> (raw)
In-Reply-To: <1112992701.26296.16.camel@dhcp153.mvista.com>
* Daniel Walker <dwalker@mvista.com> wrote:
> I submitted a fix for this a while ago, I think ..
> interruptible_sleep_on()'s are broken ..
sleep_on() is a fundamentally broken interface, it only works on UP -
but there it _does_ rely on the behavior your patch removes. (i.e.
disabled interrupts until we hit schedule())
the PREEMPT_RT kernel makes the limitations of sleep_on() even more
apparent. The patch only removes the warning, it doesnt remove the race.
To remove the race, sleep_on() usage should be converted to something
else. (e.g. one of the wait_event() variants)
Ingo
next prev parent reply other threads:[~2005-04-09 4:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-08 20:15 'BUG: scheduling with irqs disabled' when umounting NFS volume Lee Revell
2005-04-08 20:38 ` Daniel Walker
2005-04-08 21:51 ` Lee Revell
2005-04-11 16:29 ` Daniel Walker
2005-04-11 16:37 ` Lee Revell
2005-04-09 4:44 ` Ingo Molnar [this message]
2005-04-11 16:52 ` Daniel Walker
2005-04-10 10:27 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050409044449.GA2857@elte.hu \
--to=mingo@elte.hu \
--cc=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rlrevell@joe-job.com \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.