From: Dave Jones <davej@redhat.com>
To: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: cpufreq@lists.linux.org.uk, Eric Piel <Eric.Piel@tremplin-utc.net>
Subject: Re: [PATCH] cpufreq: fix latency comment in cpufreq.h [Was: Re: [PATCH] AMD Elan SC520 cpufreq driver]
Date: Sat, 9 Apr 2005 17:43:39 -0400 [thread overview]
Message-ID: <20050409214339.GA15030@redhat.com> (raw)
In-Reply-To: <20050409202055.GA30626@dominikbrodowski.de>
On Sat, Apr 09, 2005 at 10:20:55PM +0200, Dominik Brodowski wrote:
> On Mon, Apr 04, 2005 at 01:53:04AM +0200, Eric Piel wrote:
> > Sean Young a écrit :
> > >- policy->cpuinfo.transition_latency = CPUFREQ_ETERNAL;
> > >+ policy->cpuinfo.transition_latency = 1000; /* 1ms */
> >
> > transition_latency is expressed in nanoseconds, so it should be 1000000.
> > I guess the confusion comes from cpufreq.h, where there are two comments
> > about it, one saying it's nanosecond, another one (older) saying it's
> > microseconds. Dominik, maybe this typo should be fixed, do you want me
> > to send a patch?
>
> Nice catch.
>
>
> Fix up comment in cpufreq.h stating transition latency should be passed
> in microseconds -- it was decided long ago to switch to nanoseconds.
>
> Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
With Linus not merging anything right now due to the bitkeeper
fiasco, I'm just sitting on a bunch of stuff.
I'm not asking you (and others) not to send stuff, but be prepared
to bomb me again once Linus has figured out how things are going
to work.
Cheers,
Dave
prev parent reply other threads:[~2005-04-09 21:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-29 21:36 [PATCH] AMD Elan SC520 cpufreq driver Sean Young
2005-03-29 21:50 ` Eric Piel
2005-03-29 23:42 ` Sean Young
2005-03-29 22:04 ` Dominik Brodowski
2005-04-03 16:27 ` Sean Young
2005-04-03 23:53 ` Eric Piel
2005-04-09 20:20 ` [PATCH] cpufreq: fix latency comment in cpufreq.h [Was: Re: [PATCH] AMD Elan SC520 cpufreq driver] Dominik Brodowski
2005-04-09 21:43 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050409214339.GA15030@redhat.com \
--to=davej@redhat.com \
--cc=Eric.Piel@tremplin-utc.net \
--cc=cpufreq@lists.linux.org.uk \
--cc=linux@dominikbrodowski.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.