All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Derek Cheung <derek.cheung@sympatico.ca>
Cc: "'Randy.Dunlap'" <rddunlap@osdl.org>,
	"'Andrew Morton'" <akpm@osdl.org>,
	Linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel 2.6.11.6 -  I2C adaptor for ColdFire 5282 CPU
Date: Mon, 11 Apr 2005 13:03:18 -0700	[thread overview]
Message-ID: <20050411200318.GA25550@kroah.com> (raw)
In-Reply-To: <000801c53ded$04428920$1501a8c0@Mainframe>

On Sun, Apr 10, 2005 at 12:47:42PM -0400, Derek Cheung wrote:
> Enclosed please find the updated patch that incorporates changes for all
> the comments I received.

You did not cc: the sensors mailing list, nor fix all of the coding
style issues.

> The volatile declaration in the m528xsim.h is needed because the
> declaration refers to the ColdFire 5282 register mapping.

Shouldn't you be calling ioremap, and not directly accessing a specific
register location through a pointer?  That's how all other arches do
this.

thanks,

greg k-h

  parent reply	other threads:[~2005-04-11 20:27 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20050405044836.GA17336@kroah.com>
2005-04-06  2:18 ` [PATCH] kernel 2.6.11.6 - I2C adaptor for ColdFire 5282 CPU Derek Cheung
2005-04-06  2:21   ` Andrew Morton
2005-04-06  2:33     ` Derek Cheung
2005-04-06  3:10       ` Randy.Dunlap
2005-04-07 22:37         ` Matt Mackall
2005-04-07 22:42           ` [PATCH] Add dontdiff file Randy.Dunlap
2005-04-06  3:43       ` [PATCH] kernel 2.6.11.6 - I2C adaptor for ColdFire 5282 CPU Randy.Dunlap
2005-04-06 14:25         ` Greg KH
2005-04-10 16:47         ` Derek Cheung
2005-04-10 23:54           ` Andrew Morton
2005-04-11  3:32           ` Randy.Dunlap
2005-04-11 20:03           ` Greg KH [this message]
2005-04-14  1:12             ` Derek Cheung
2005-05-19  6:25               ` Derek Cheung
2005-04-17 22:03               ` Greg KH
2005-05-19  6:25                 ` Greg KH
2005-04-18 21:10               ` Jean Delvare
2005-05-19  6:25                 ` Jean Delvare
2005-04-06  3:27   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050411200318.GA25550@kroah.com \
    --to=greg@kroah.com \
    --cc=Linux-kernel@vger.kernel.org \
    --cc=akpm@osdl.org \
    --cc=derek.cheung@sympatico.ca \
    --cc=rddunlap@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.