All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Alex Aizman <itn780@yahoo.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [ANNOUNCE 2/6] Linux-iSCSI High-Performance Initiator
Date: Mon, 11 Apr 2005 22:34:15 -0700	[thread overview]
Message-ID: <20050412053415.GD32372@kroah.com> (raw)
In-Reply-To: <425B3F58.2040000@yahoo.com>

> +struct iscsi_hdr {
> +	uint8_t		opcode;
> +	uint8_t		flags;		/* Final bit */
> +	uint8_t		rsvd2[2];
> +	uint8_t		hlength;	/* AHSs total length */
> +	uint8_t		dlength[3];	/* Data length */
> +	uint8_t		lun[8];
> +	uint32_t	itt;		/* Initiator Task Tag */
> +	uint32_t	ttt;		/* Target Task Tag */
> +	uint32_t	statsn;
> +	uint32_t	exp_statsn;
> +	uint8_t		other[16];

Please use u8 and u32 instead of the types you used here.  See the lkml
archives for many threads about this topic.

thanks,

greg k-h

  reply	other threads:[~2005-04-12  5:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-12  3:24 [ANNOUNCE 2/6] Linux-iSCSI High-Performance Initiator Alex Aizman
2005-04-12  5:34 ` Greg KH [this message]
2005-04-12  5:35 ` Greg KH
2005-04-12 16:34   ` Dmitry Yusupov
2005-04-12  5:36 ` Greg KH
2005-04-12  7:27   ` Christoph Hellwig
2005-04-12  7:45     ` Greg KH
2005-04-12  8:14       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050412053415.GD32372@kroah.com \
    --to=greg@kroah.com \
    --cc=itn780@yahoo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.