From: "Dale Farnsworth" <dale@farnsworth.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Andrew Morton <akpm@osdl.org>, Jeff Garzik <jgarzik@pobox.com>,
netdev@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ppc32: MV643XX ethernet is an option for Pegasos
Date: Tue, 12 Apr 2005 02:55:22 -0700 [thread overview]
Message-ID: <20050412095522.GA20129@xyzzy> (raw)
In-Reply-To: <1113289985.21548.66.camel@gaston>
On Tue, Apr 12, 2005 at 07:13:04AM +0000, Benjamin Herrenschmidt wrote:
> This patch allows Kconfig to build the MV643xx ethernet driver on
> Pegasos (CONFIG_PPC_MULTIPLATFORM) and adds what I think is a missing
> fix from Dale's batch, that is remove SA_INTERRUPT and add SA_SHIRQ in
> there as the interrupt is shared if I understand things correctly.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Fabio Massimo Di Nitto <fabbione@ubuntu.com>
This looks identical to the patch I posted to netdev two weeks ago
as the first of 20 patches for the MV643xx ethernet driver.
See <http://oss.sgi.com/archives/netdev/2005-03/msg01644.html> and
<http://oss.sgi.com/archives/netdev/2005-03/msg01642.html>.
Thanks,
-Dale
> #! /bin/sh -e
>
> . $(dirname $0)/DPATCH
>
> @DPATCH@
> diff -urNad linux-source-2.6.12-2.6.11.90/drivers/net/Kconfig /usr/src/dpatchtemp/dpep.nYRoKc/linux-source-2.6.12-2.6.11.90/drivers/net/Kconfig
> --- linux-source-2.6.12-2.6.11.90/drivers/net/Kconfig 2005-04-11 16:13:06.000000000 +0200
> +++ /usr/src/dpatchtemp/dpep.nYRoKc/linux-source-2.6.12-2.6.11.90/drivers/net/Kconfig 2005-04-12 08:05:33.535955920 +0200
> @@ -2044,7 +2044,7 @@
>
> config MV643XX_ETH
> tristate "MV-643XX Ethernet support"
> - depends on MOMENCO_OCELOT_C || MOMENCO_JAGUAR_ATX || MV64360 || MOMENCO_OCELOT_3
> + depends on MOMENCO_OCELOT_C || MOMENCO_JAGUAR_ATX || MV64360 || MOMENCO_OCELOT_3 || PPC_MULTIPLATFORM
> help
> This driver supports the gigabit Ethernet on the Marvell MV643XX
> chipset which is used in the Momenco Ocelot C and Jaguar ATX and
> diff -urNad linux-source-2.6.12-2.6.11.90/drivers/net/mv643xx_eth.c /usr/src/dpatchtemp/dpep.nYRoKc/linux-source-2.6.12-2.6.11.90/drivers/net/mv643xx_eth.c
> --- linux-source-2.6.12-2.6.11.90/drivers/net/mv643xx_eth.c 2005-04-07 14:57:16.000000000 +0200
> +++ /usr/src/dpatchtemp/dpep.nYRoKc/linux-source-2.6.12-2.6.11.90/drivers/net/mv643xx_eth.c 2005-04-12 08:07:36.246301112 +0200
> @@ -668,7 +668,7 @@
> spin_lock_irq(&mp->lock);
>
> err = request_irq(dev->irq, mv643xx_eth_int_handler,
> - SA_INTERRUPT | SA_SAMPLE_RANDOM, dev->name, dev);
> + SA_SHIRQ | SA_SAMPLE_RANDOM, dev->name, dev);
>
> if (err) {
> printk(KERN_ERR "Can not assign IRQ number to MV643XX_eth%d\n",
>
next prev parent reply other threads:[~2005-04-12 9:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-12 7:13 [PATCH] ppc32: MV643XX ethernet is an option for Pegasos Benjamin Herrenschmidt
2005-04-12 9:55 ` Dale Farnsworth [this message]
2005-04-12 10:44 ` Fabio Massimo Di Nitto
2005-04-12 12:08 ` Dale Farnsworth
2005-04-12 23:16 ` Benjamin Herrenschmidt
2005-04-12 10:49 ` Sven Luther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050412095522.GA20129@xyzzy \
--to=dale@farnsworth.org \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.