From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gerd Knorr <kraxel@bytesex.org>
Subject: Re: [patch] pagetable cleanups
Date: Thu, 14 Apr 2005 17:31:30 +0200
Message-ID: <20050414153130.GB28071@bytesex>
References: <A95E2296287EAD4EB592B5DEEFCE0E9D1E3B77@liverpoolst.ad.cl.cam.ac.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <A95E2296287EAD4EB592B5DEEFCE0E9D1E3B77@liverpoolst.ad.cl.cam.ac.uk>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Pratt <m+Ian.Pratt@cl.cam.ac.uk>
Cc: Michael A Fetterman <Michael.Fetterman@cl.cam.ac.uk>, xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

> Personally think having "a = foo(b,c)" is actually more readable than
> "foo(&a,b,c)".

In that case yes.
If you use that to avoid extra temporary variables, i.e.

	bar(x, foo(b,c));

instead of

	a = foo(b,c);
	bar(x,a);

it quickly becomes unreadable, especially if the function and argument
names are a bit longer and the first version doesn't fit onto a single
line any more.  You are not forced to do that though, even if the
macros/functions _do_ return the entries ;)

I'll go over it again ...

  Gerd

-- 
#define printk(args...) fprintf(stderr, ## args)