From: Adrian Bunk <bunk@stusta.de>
To: bcollins@debian.org, scjody@steamballoon.com
Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: [2.6 patch] drivers/ieee1394/ieee1394_transactions.c: possible cleanups
Date: Tue, 19 Apr 2005 02:45:23 +0200 [thread overview]
Message-ID: <20050419004523.GK5489@stusta.de> (raw)
This patch contains the following possible cleanups:
- #if 0 the following unused global functions:
- hpsb_lock
- hpsb_send_gasp
- ieee1394_transactions.h: remove the stale hpsb_lock64 prototype
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/ieee1394/ieee1394_transactions.c | 3 +++
drivers/ieee1394/ieee1394_transactions.h | 7 -------
2 files changed, 3 insertions(+), 7 deletions(-)
--- linux-2.6.12-rc2-mm3-full/drivers/ieee1394/ieee1394_transactions.h.old 2005-04-19 00:24:13.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/ieee1394/ieee1394_transactions.h 2005-04-19 00:25:00.000000000 +0200
@@ -53,12 +53,5 @@
u64 addr, quadlet_t *buffer, size_t length);
int hpsb_write(struct hpsb_host *host, nodeid_t node, unsigned int generation,
u64 addr, quadlet_t *buffer, size_t length);
-int hpsb_lock(struct hpsb_host *host, nodeid_t node, unsigned int generation,
- u64 addr, int extcode, quadlet_t *data, quadlet_t arg);
-int hpsb_lock64(struct hpsb_host *host, nodeid_t node, unsigned int generation,
- u64 addr, int extcode, octlet_t *data, octlet_t arg);
-int hpsb_send_gasp(struct hpsb_host *host, int channel, unsigned int generation,
- quadlet_t *buffer, size_t length, u32 specifier_id,
- unsigned int version);
#endif /* _IEEE1394_TRANSACTIONS_H */
--- linux-2.6.12-rc2-mm3-full/drivers/ieee1394/ieee1394_transactions.c.old 2005-04-19 00:24:31.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/ieee1394/ieee1394_transactions.c 2005-04-19 00:24:51.000000000 +0200
@@ -535,6 +535,7 @@
return retval;
}
+#if 0
int hpsb_lock(struct hpsb_host *host, nodeid_t node, unsigned int generation,
u64 addr, int extcode, quadlet_t *data, quadlet_t arg)
@@ -599,3 +600,5 @@
return retval;
}
+
+#endif /* 0 */
next reply other threads:[~2005-04-19 0:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-19 0:45 Adrian Bunk [this message]
2005-04-21 20:45 ` [2.6 patch] drivers/ieee1394/ieee1394_transactions.c: possible cleanups Jody McIntyre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050419004523.GK5489@stusta.de \
--to=bunk@stusta.de \
--cc=bcollins@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=scjody@steamballoon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.