From: Gerd Knorr <kraxel@bytesex.org>
To: Hollis Blanchard <hollisb@us.ibm.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [request for review] cmpxchg8b asm stuff
Date: Tue, 19 Apr 2005 21:39:59 +0200 [thread overview]
Message-ID: <20050419193958.GA21651@bytesex> (raw)
In-Reply-To: <1113925602.8217.3.camel@localhost.localdomain>
> > +++ xen/arch/x86/mm.c 2005-04-19 15:29:01.000000000 +0200
> >
> > +static inline int cmpxchg8b_user(u64 *ptr, u64 oval, u64 nval)
> Shouldn't this go into include/asm-x86/system.h?
Well, maybe later. I want to have it working correctly first, then
optimize and then check how to integrate that nicely.
> You can add another case to the __i386__ cmpxchg_user switch.
That would be the most obvious place, yes. Not fully sure yet that this
is really a good idea though as it is sort-of special case for 64bit
data on a 32bit machine, you have to split the 64bit values into two
32bit regs and so on (unlike the 64bit version on x86_64 which simply
uses the 64bit registers). Maybe it's better to keep that separate as
it might be easier to optimize it then, not evaluated yet.
Gerd
--
#define printk(args...) fprintf(stderr, ## args)
next prev parent reply other threads:[~2005-04-19 19:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-19 13:50 [request for review] cmpxchg8b asm stuff Gerd Knorr
2005-04-19 15:46 ` Hollis Blanchard
2005-04-19 19:39 ` Gerd Knorr [this message]
2005-04-21 10:54 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050419193958.GA21651@bytesex \
--to=kraxel@bytesex.org \
--cc=hollisb@us.ibm.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.