From: Domen Puncer <domen@coderock.org>
To: "YOSHIFUJI Hideaki / ?$B5HF#1QL@" <yoshfuji@linux-ipv6.org>
Cc: vda@port.imtp.ilyichevsk.odessa.ua, linux-kernel@vger.kernel.org,
mpm@selenic.com
Subject: Re: [PATCH] introduce generic 64bit rotations and i386 asm optimized version
Date: Tue, 19 Apr 2005 22:20:38 +0200 [thread overview]
Message-ID: <20050419202037.GE21272@nd47.coderock.org> (raw)
In-Reply-To: <20050419.154642.111848378.yoshfuji@linux-ipv6.org>
On 19/04/05 15:46 +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ wrote:
> In article <200504190918.10279.vda@port.imtp.ilyichevsk.odessa.ua> (at Tue, 19 Apr 2005 09:18:10 +0300), Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua> says:
>
> > diff -urpN 2.6.12-rc2.1.be/include/linux/bitops.h 2.6.12-rc2.2.ror/include/linux/bitops.h
> > --- 2.6.12-rc2.1.be/include/linux/bitops.h Mon Apr 18 22:55:10 2005
> > +++ 2.6.12-rc2.2.ror/include/linux/bitops.h Tue Apr 19 00:25:28 2005
...
> > -static __inline__ int get_bitmask_order(unsigned int count)
> > +static inline int get_bitmask_order(unsigned int count)
> > {
> > int order;
> >
>
> Please keep using __inline__, not inline.
Why?
Couldn't find any threads about this, and even SubmittingPatches has:
"'static inline' is preferred over 'static __inline__'..."
Domen
next prev parent reply other threads:[~2005-04-19 20:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-19 6:18 [PATCH] introduce generic 64bit rotations and i386 asm optimized version Denis Vlasenko
2005-04-19 6:21 ` [PATCH] sha512: replace open-coded be64 conversions Denis Vlasenko
2005-04-19 6:26 ` [PATCH] sha512: use 64bit rotations Denis Vlasenko
2005-04-19 6:28 ` [PATCH] sha512: fix whitespace Denis Vlasenko
2005-04-19 6:31 ` [PATCH] ia64: use 64bit rotations Denis Vlasenko
2005-04-19 9:04 ` [PATCH] sha512: replace open-coded be64 conversions Jesper Juhl
2005-04-19 14:12 ` Denis Vlasenko
2005-04-19 14:41 ` Jesper Juhl
2005-04-19 14:49 ` Denis Vlasenko
2005-04-19 6:46 ` [PATCH] introduce generic 64bit rotations and i386 asm optimized version YOSHIFUJI Hideaki / 吉藤英明
2005-04-19 6:55 ` Denis Vlasenko
2005-04-19 20:20 ` Domen Puncer [this message]
2005-04-20 20:47 ` Ralf Baechle
2005-04-19 19:15 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050419202037.GE21272@nd47.coderock.org \
--to=domen@coderock.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=vda@port.imtp.ilyichevsk.odessa.ua \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.