From: Andy Isaacson <adi@hexapodia.org>
To: Kyle Hayes <kyle@marchex.com>
Cc: azarah@nosferatu.za.org, git@vger.kernel.org
Subject: Re: [patch] fixup GECOS handling
Date: Fri, 22 Apr 2005 16:30:12 -0700 [thread overview]
Message-ID: <20050422233012.GA27638@hexapodia.org> (raw)
In-Reply-To: <1114186599.31076.409.camel@axer.marchex.com>
On Fri, Apr 22, 2005 at 09:16:39AM -0700, Kyle Hayes wrote:
> if(comma)
> if(semi)
> /* lastname, firstname; room #; phone # format */
> *semi = 0;
> else
> *comma = 0;
> else if(semi)
> *semi = 0;
That's a really complicated way of writing
if(semi) *semi = 0;
else if(comma) *comma = 0;
(The two code fragments are precisely identical. Mmmm, strength
reduction.)
-andy
next prev parent reply other threads:[~2005-04-22 23:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-18 10:36 [patch] fixup GECOS handling Martin Schlemmer
2005-04-18 12:35 ` David Woodhouse
2005-04-18 12:58 ` Martin Schlemmer
2005-04-22 14:23 ` Martin Schlemmer
2005-04-22 16:16 ` Kyle Hayes
2005-04-22 16:58 ` Martin Schlemmer
2005-04-22 17:18 ` Petr Baudis
2005-04-22 17:25 ` Martin Schlemmer
2005-04-22 17:58 ` Kyle Hayes
2005-04-22 19:06 ` Martin Schlemmer
2005-04-22 20:46 ` Kyle Hayes
2005-04-23 23:38 ` Petr Baudis
2005-04-23 23:49 ` Martin Schlemmer
2005-04-22 17:43 ` Kyle Hayes
2005-04-22 23:30 ` Andy Isaacson [this message]
2005-04-25 17:02 ` Kyle Hayes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050422233012.GA27638@hexapodia.org \
--to=adi@hexapodia.org \
--cc=azarah@nosferatu.za.org \
--cc=git@vger.kernel.org \
--cc=kyle@marchex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.