From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] swsusp: misc cleanups [4/4]
Date: Sun, 24 Apr 2005 00:07:57 +0200 [thread overview]
Message-ID: <20050423220757.GD1884@elf.ucw.cz> (raw)
In-Reply-To: <200504232338.43297.rjw@sisk.pl>
Hi!
> The following patch makes some comments and printk()s in swsusp.c up to date.
> In particular it adds the string "swsusp" before every message that is printed by
> the code in swsusp.c.
I don't like this one. Adding swsusp everywhere just clutters the
screen, most of it should be clear from context.
> @@ -1226,9 +1222,6 @@ static int check_sig(void)
>
> /**
> * data_read - Read image pages from swap.
> - *
> - * You do not need to check for overlaps, check_pagedir()
> - * already did that.
> */
>
> static int data_read(struct pbe *pblist)
Why is this comment no longer valid?
Pavel
--
Boycott Kodak -- for their patent abuse against Java.
next prev parent reply other threads:[~2005-04-23 22:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-23 21:20 [PATCH] swsusp: misc cleanups [0/4] Rafael J. Wysocki
2005-04-23 21:25 ` [PATCH] swsusp: misc cleanups [1/4] Rafael J. Wysocki
2005-04-23 22:05 ` Pavel Machek
2005-04-23 21:29 ` [PATCH] swsusp: misc cleanups [2/4] Rafael J. Wysocki
2005-04-23 22:02 ` Pavel Machek
2005-04-23 21:34 ` [PATCH] swsusp: misc cleanups [3/4] Rafael J. Wysocki
2005-04-23 22:18 ` Pavel Machek
2005-04-24 10:41 ` Rafael J. Wysocki
2005-04-24 20:23 ` Pavel Machek
2005-04-23 21:38 ` [PATCH] swsusp: misc cleanups [4/4] Rafael J. Wysocki
2005-04-23 22:07 ` Pavel Machek [this message]
2005-04-24 10:30 ` Rafael J. Wysocki
2005-04-24 20:20 ` Pavel Machek
2005-04-24 10:57 ` Stefan Seyfried
2005-04-24 20:22 ` Pavel Machek
2005-04-24 20:43 ` Stefan Seyfried
2005-04-24 21:03 ` Pavel Machek
2005-04-23 21:58 ` [PATCH] swsusp: misc cleanups [0/4] Pavel Machek
2005-04-24 10:06 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050423220757.GD1884@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.