From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adam Belay Subject: Re: [PATCH] PCI: Add pci shutdown ability Date: Mon, 25 Apr 2005 16:24:55 -0400 Message-ID: <20050425202454.GE27771@neo.rr.com> References: <20050425182951.GA23209@kroah.com> <20050425185113.GC23209@kroah.com> <20050425190606.GA23763@kroah.com> <20050425200825.GA3951@neo.rr.com> <20050425201949.GA24695@kroah.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============52050261687757349==" Return-path: In-Reply-To: <20050425201949.GA24695@kroah.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.osdl.org Errors-To: linux-pm-bounces@lists.osdl.org To: Greg KH Cc: akpm@osdl.org, Amit Gud , USB development list , Pavel Machek , Linux-pm mailing list , linux-pci@atrey.karlin.mff.cuni.cz, jgarzik@pobox.com, linux-kernel@vger.kernel.org, cramerj@intel.com List-Id: linux-pm@vger.kernel.org --===============52050261687757349== Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 25, 2005 at 01:19:49PM -0700, Greg KH wrote: > On Mon, Apr 25, 2005 at 04:08:25PM -0400, Adam Belay wrote: > > I think this could be important for any type of device, so the power > > management subsystem and driver core should handle it. I'm not really > > sure if it's useful in pci alone, as it lacks the necessary ordering and > > coordination. > > The driver core today _does_ handle this properly, and in the correct > order. I'm just allowing pci drivers access to that functionality, as > today they can not take advantage of it. That's all this patch does. sorry, I didn't notice this after a quick glance :) > + drv->driver.shutdown = pci_device_shutdown, Ok, great. I understand. > > > I'm currently developing an interface for quieting devices without turning > > them off in my Power Management model. Pavel seems to also have plans along > > those lines: > > I think the intention here may have been to use PM_FREEZE via *suspend. It isn't currently supported though. > > Great, then it will tie into the current driver model code, which will > then call the proper pci driver code, and everyone will be happy :) > > thanks, > > greg k-h Thanks, Adam --===============52050261687757349== Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline --===============52050261687757349==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261160AbVDYUf1 (ORCPT ); Mon, 25 Apr 2005 16:35:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261182AbVDYUcu (ORCPT ); Mon, 25 Apr 2005 16:32:50 -0400 Received: from HELIOUS.MIT.EDU ([18.248.3.87]:53161 "EHLO neo.rr.com") by vger.kernel.org with ESMTP id S261165AbVDYU3G (ORCPT ); Mon, 25 Apr 2005 16:29:06 -0400 Date: Mon, 25 Apr 2005 16:24:55 -0400 From: Adam Belay To: Greg KH Cc: Pavel Machek , Amit Gud , Alan Stern , linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz, akpm@osdl.org, jgarzik@pobox.com, cramerj@intel.com, USB development list , Linux-pm mailing list Subject: Re: [PATCH] PCI: Add pci shutdown ability Message-ID: <20050425202454.GE27771@neo.rr.com> Mail-Followup-To: Adam Belay , Greg KH , Pavel Machek , Amit Gud , Alan Stern , linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz, akpm@osdl.org, jgarzik@pobox.com, cramerj@intel.com, USB development list , Linux-pm mailing list References: <20050425182951.GA23209@kroah.com> <20050425185113.GC23209@kroah.com> <20050425190606.GA23763@kroah.com> <20050425200825.GA3951@neo.rr.com> <20050425201949.GA24695@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050425201949.GA24695@kroah.com> User-Agent: Mutt/1.5.6+20040907i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 25, 2005 at 01:19:49PM -0700, Greg KH wrote: > On Mon, Apr 25, 2005 at 04:08:25PM -0400, Adam Belay wrote: > > I think this could be important for any type of device, so the power > > management subsystem and driver core should handle it. I'm not really > > sure if it's useful in pci alone, as it lacks the necessary ordering and > > coordination. > > The driver core today _does_ handle this properly, and in the correct > order. I'm just allowing pci drivers access to that functionality, as > today they can not take advantage of it. That's all this patch does. sorry, I didn't notice this after a quick glance :) > + drv->driver.shutdown = pci_device_shutdown, Ok, great. I understand. > > > I'm currently developing an interface for quieting devices without turning > > them off in my Power Management model. Pavel seems to also have plans along > > those lines: > > I think the intention here may have been to use PM_FREEZE via *suspend. It isn't currently supported though. > > Great, then it will tie into the current driver model code, which will > then call the proper pci driver code, and everyone will be happy :) > > thanks, > > greg k-h Thanks, Adam