From: Manish Singh <manish.singh@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] Re: [Ocfs2-commits] manish commits r2175 - in trunk/fs/ocfs2: . cluster dlm
Date: Tue Apr 26 03:52:17 2005 [thread overview]
Message-ID: <20050426084753.GA8236@ca-server1.us.oracle.com> (raw)
In-Reply-To: <20050426082033.GA18736@lst.de>
On Tue, Apr 26, 2005 at 10:20:33AM +0200, Christoph Hellwig wrote:
> On Tue, Apr 26, 2005 at 01:15:38AM -0700, Manish Singh wrote:
> > The issue here is format string readability vs. printk argument
> > readability. Both magic format defines and verbose (unsigned long long)
> > casts make the code harder to read. Why is format string readability
> > preferred?
>
> I don't know ;-) But if magic format strings we preferred we'd have
> them in a common place.
Perhaps they should be in some common place then? The kernel could
provide the C99 macros for dealing with explicitly sized types.
It sounds like the reason it doesn't exist already is simply because
nobody has done it yet. Printing 64-bit types in non-arch specific code
is rare in the current kernel tree, which is probably why nobody has
cared yet. I don't really see any evidence of a specific precedent set
against doing so.
-Manish
next prev parent reply other threads:[~2005-04-26 3:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200504260323.j3Q3NC9V013089@oss.oracle.com>
2005-04-26 2:18 ` [Ocfs2-devel] Re: [Ocfs2-commits] manish commits r2175 - in trunk/fs/ocfs2: . cluster dlm Christoph Hellwig
2005-04-26 3:18 ` Manish Singh
2005-04-26 3:25 ` Christoph Hellwig
2005-04-26 3:52 ` Manish Singh [this message]
2005-04-26 3:58 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050426084753.GA8236@ca-server1.us.oracle.com \
--to=manish.singh@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.