From: Andrew Morton <akpm@osdl.org>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] counting bounce buffer in vmstat
Date: Tue, 26 Apr 2005 23:47:25 -0700 [thread overview]
Message-ID: <20050426234725.1ed66aff.akpm@osdl.org> (raw)
In-Reply-To: <426F3445.9060701@jp.fujitsu.com>
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
>
> diff -puN include/linux/page-flags.h~count_bounce include/linux/page-flags.h
> --- linux-2.6.12-rc2-mm3/include/linux/page-flags.h~count_bounce 2005-04-27 10:23:15.000000000 +0900
> +++ linux-2.6.12-rc2-mm3-kamezawa/include/linux/page-flags.h 2005-04-27 10:24:11.000000000 +0900
> @@ -89,6 +89,7 @@ struct page_state {
> unsigned long nr_page_table_pages;/* Pages used for pagetables */
> unsigned long nr_mapped; /* mapped into pagetables */
> unsigned long nr_slab; /* In slab */
> + unsigned long nr_bounce; /* pages for bounce buffers */
> #define GET_PAGE_STATE_LAST nr_slab
That's not really right.
There are two functions: get_page_state() and get_full_page_state().
get_page_state() only gets those fields up to and including
GET_PAGE_STATE_LAST. The way you have the code laid out there implies that
get_page_state() also calculates the total nr_bounce, only it doesn't.
I'll fix it up.
next prev parent reply other threads:[~2005-04-27 6:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-27 6:42 [PATCH] counting bounce buffer in vmstat KAMEZAWA Hiroyuki
2005-04-27 6:47 ` Andrew Morton [this message]
2005-04-27 7:14 ` KAMEZAWA Hiroyuki
2005-04-27 6:50 ` YOSHIFUJI Hideaki / 吉藤英明
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050426234725.1ed66aff.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.