From: Arnd Bergmann <arnd@arndb.de>
To: Olof Johansson <olof@lixom.net>
Cc: linuxppc64-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org, Anton Blanchard <anton@samba.org>
Subject: Re: [PATCH 3/4] ppc64: Add driver for BPA iommu
Date: Fri, 29 Apr 2005 07:48:27 +0200 [thread overview]
Message-ID: <200504290748.30055.arnd@arndb.de> (raw)
In-Reply-To: <20050429053615.GA30219@lixom.net>
On Freedag 29 April 2005 07:36, Olof Johansson wrote:
> On Fri, Apr 29, 2005 at 06:35:43AM +0200, Arnd Bergmann wrote:
>>
> Anyhow, enum or #define, it should be moved to bpa_iommu.h.
I don't interface with any other files, so I prefer to have
everything in one file here. If there is anyone else who
agrees with you on moving this into a separate file, I don't
mind doing that.
> User or developer error? I thought it was a developer one, and a quite
> specialized one at that. Either way, there's already a primitive that
> can be used instead of making your own: BUILD_BUG_ON().
Right. I had forgotten about that, thanks.
> > Yes, but it seems to contradict the specs...
>
> A comment to that effect could be nice.
Ok, I'll change that.
> > This comes from a graphical representation in the specs. I'll add a comment
> > to point to that image.
>
> I guess it'd be a bit much information to just add in a comment, but for
> readability that's probably the best way to go. Not many people have
> the specs, but on the other hand if you're messing around with this code
> then chances are you have them.
The picture should be in the parts that we are working on getting public.
> I don't know what the status is for a release of public specifications,
> but if they're not available then people will be looking to learn from
> the implementation and the documentation around it instead.
There will be a supplement to Book 1-3 of PowerPC AS that is going to
be public. Book 4 is rarely needed and the chances of publishing that
are not as good.
Thanks,
Arnd <><
next prev parent reply other threads:[~2005-04-29 5:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-28 7:54 [PATCH 0/4] ppc64: Introduce BPA platform Arnd Bergmann
2005-04-28 7:56 ` [PATCH 1/4] ppc64: add BPA platform type Arnd Bergmann
2005-04-28 7:58 ` [PATCH 2/4] ppc64: Add driver for BPA interrupt controllers Arnd Bergmann
2005-04-28 7:59 ` [PATCH 3/4] ppc64: Add driver for BPA iommu Arnd Bergmann
2005-04-28 14:05 ` Olof Johansson
2005-04-28 14:30 ` Olof Johansson
2005-04-29 4:35 ` Arnd Bergmann
2005-04-29 5:36 ` Olof Johansson
2005-04-29 5:48 ` Arnd Bergmann [this message]
2005-04-29 6:43 ` Benjamin Herrenschmidt
2005-04-29 8:31 ` Arnd Bergmann
2005-04-29 13:06 ` Paul Mackerras
2005-04-28 8:00 ` [PATCH 4/4] ppc64: Add SPU file system Arnd Bergmann
2005-04-28 14:44 ` [PATCH 0/4] ppc64: Introduce BPA platform Sonny Rao
2005-04-29 4:35 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200504290748.30055.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@ozlabs.org \
--cc=olof@lixom.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.