All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@davemloft.net>
To: Grant Grundler <grundler@parisc-linux.org>
Cc: benh@kernel.crashing.org, grundler@parisc-linux.org,
	linux-pci@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org,
	greg@kroah.com, bjorn.helgaas@hp.com, davem@redhat.com
Subject: Re: pci-sysfs resource mmap broken (and PATCH)
Date: Fri, 29 Apr 2005 08:42:42 -0700	[thread overview]
Message-ID: <20050429084242.38db3aeb.davem@davemloft.net> (raw)
In-Reply-To: <20050428233828.GI10171@colo.lackof.org>

On Thu, 28 Apr 2005 17:38:28 -0600
Grant Grundler <grundler@parisc-linux.org> wrote:

> I suspect the MAP_* attribute/hint needs to be passed in together
> with the mmap call if any arch (ia64?) would return a different
> virtual address depending the attribute (e.g cached vs uncached).

The only problem could me getting the generic mmap() code to
properly pass the flag down into the driver, I seem to recall
that it either does an -EINVAL or masks out any flags which
are not in the standard set.

But then again this conflicts with what I remember seeing in the
XFree86 PCI support, in that IA64 passed in such a mmap() flag
to indicate a framebuffer like mapping that didn't need a guard-like
bit to be set.

Someone should look at the code to make sure :-)


  reply	other threads:[~2005-04-29 15:52 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-26  5:33 pci-sysfs resource mmap broken Benjamin Herrenschmidt
2005-04-26  6:09 ` Benjamin Herrenschmidt
2005-04-26  6:36   ` Greg KH
2005-04-26  9:24   ` Russell King
2005-04-26 16:30 ` Grant Grundler
2005-04-26 22:47   ` Benjamin Herrenschmidt
2005-04-27  3:55     ` Grant Grundler
2005-04-27  4:30       ` Benjamin Herrenschmidt
2005-04-27  4:28         ` David S. Miller
2005-04-27  4:39           ` Benjamin Herrenschmidt
2005-04-27  4:46     ` pci-sysfs resource mmap broken (and PATCH) Benjamin Herrenschmidt
2005-04-27 23:13     ` Benjamin Herrenschmidt
2005-04-28  5:33       ` Grant Grundler
2005-04-28  5:37         ` David S. Miller
2005-04-28  6:39           ` Benjamin Herrenschmidt
2005-04-28  6:50             ` David S. Miller
2005-04-28  7:21               ` Benjamin Herrenschmidt
2005-04-28  7:22                 ` David S. Miller
2005-04-28  7:46                   ` Benjamin Herrenschmidt
2005-04-28 15:11               ` Grant Grundler
2005-04-28 22:47                 ` Benjamin Herrenschmidt
2005-04-28 23:38                   ` Grant Grundler
2005-04-29 15:42                     ` David S. Miller [this message]
2005-04-29 22:16                       ` Jesse Barnes
2005-04-28  6:35         ` Benjamin Herrenschmidt
2005-05-03  5:37           ` pci-sysfs resource mmap broken PATCH#2 Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050429084242.38db3aeb.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=benh@kernel.crashing.org \
    --cc=bjorn.helgaas@hp.com \
    --cc=davem@redhat.com \
    --cc=greg@kroah.com \
    --cc=grundler@parisc-linux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.