All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Parish <srparish@us.ibm.com>
To: Gerd Knorr <kraxel@bytesex.org>
Cc: xen-devel@lists.xensource.com
Subject: Re: PAE xen + linux kernel boots ...
Date: Sat, 30 Apr 2005 09:51:24 +0000	[thread overview]
Message-ID: <20050430095123.GE16883@us.ibm.com> (raw)
In-Reply-To: <20050430090117.GC16883@us.ibm.com>

On Sat, Apr 30, 2005 at 09:01:17AM +0000, Scott Parish wrote:

> On Wed, Apr 27, 2005 at 02:03:17PM +0200, Gerd Knorr wrote:
> 
> > Well, now it does, boots up to a login prompt ;)
> 
> pl1e would straddle a page boundary

I swear there is a muse associated with the send button on email
clients.

In this case the epiphany was the obvious--the problem was that we're
missing alignment. But why?

On the linux side of things we have the following in pgtable-3level.h:

   #if 1 /* writable pagetables */
   static inline void set_pte(pte_t *ptep, pte_t pte)
   {
	    ptep->pte_high = pte.pte_high;
	    smp_wmb();
	    ptep->pte_low = pte.pte_low;
   }
   ...

Here's what (i'm thinking) is going on. We go to set the high bits
(first for atomicy: we don't set the active bit till last), but take
a page fault, on the high bits--a 4 byte offset.

Switch to xen, which is going to emulate some instructions and fake
the writing. We eventually end up in ptwr_emulated_update(), who among
other things, tries to copy the full l1_pgentry_t (64bits), but from
the 4 byte offset, that is the 4 high bytes and then 4 bytes of
undefined memory that may even be in another page.

sRp

-- 
Scott Parish

  reply	other threads:[~2005-04-30  9:51 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-25 17:26 PAE xen + linux kernel boots Gerd Knorr
2005-04-27 12:03 ` Gerd Knorr
2005-04-28 18:41   ` Chris Wright
2005-04-29  8:01     ` Gerd Knorr
2005-04-30  8:40   ` Scott Parish
2005-04-30 22:55     ` Gerd Knorr
2005-04-30  9:01   ` Scott Parish
2005-04-30  9:51     ` Scott Parish [this message]
2005-04-30 10:54       ` Keir Fraser
2005-05-01  8:12         ` Scott Parish
2005-05-02 14:03           ` Gerd Knorr
2005-05-02 16:02             ` Scott Parish
2005-05-04  2:20             ` Scott Parish
2005-05-04  8:03               ` Gerd Knorr
2005-05-04 15:20                 ` Scott Parish
2005-05-04  2:28             ` Scott Parish
2005-05-04  3:22               ` Kip Macy
2005-05-04  3:23                 ` Scott Parish
2005-05-04  7:58                   ` Gerd Knorr
2005-04-30 23:15       ` Gerd Knorr
2005-04-30 23:01     ` Gerd Knorr
2005-04-30 22:57       ` Scott Parish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050430095123.GE16883@us.ibm.com \
    --to=srparish@us.ibm.com \
    --cc=kraxel@bytesex.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.