From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Jones Subject: Re: [PATCH] dual-core powernow-k8 Date: Wed, 4 May 2005 19:27:20 -0400 Message-ID: <20050504232720.GA15810@redhat.com> References: <84EA05E2CA77634C82730353CBE3A84301CFBFD0@SAUSEXMB1.amd.com> <20050504165559.GA1286@isilmar.linta.de> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <20050504165559.GA1286@isilmar.linta.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: cpufreq-bounces@lists.linux.org.uk Errors-To: cpufreq-bounces+glkc-cpufreq=gmane.org@lists.linux.org.uk Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dominik Brodowski Cc: cpufreq@lists.linux.org.uk On Wed, May 04, 2005 at 06:55:59PM +0200, Dominik Brodowski wrote: > On Wed, May 04, 2005 at 11:53:48AM -0500, Langsdorf, Mark wrote: > > > On Mon, May 02, 2005 at 02:23:41PM -0500, Langsdorf, Mark wrote: > > > > Update the driver to version 1.40.0 and provide support > > > > for dual-core processors. > > > > > > Looks good to me, though it'd be great if you could provide > > > step-by-step patches in future (e.g. split up printk > > > cleanups, adding feature and so on...). One small bit, though: > > > > Will do. > > > > > +cpumask_t cpu_sharedcore_mask[NR_CPUS]; > > > > > > can be static, AFAICS. > > > > I'll add it to my copy. Do you want me to resubmit? > > That's Dave's call... I'm travelling for the next day or so, so I'm not going to look at much until I get back, feel free to send an incremental, or I'll just do it myself if it hasnt turned up when I return. thanks, Dave