From: Domen Puncer <domen@coderock.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] drivers/block/paride/pcd.c : replace direct
Date: Thu, 05 May 2005 17:20:37 +0000 [thread overview]
Message-ID: <20050505172037.GC3917@nd47.coderock.org> (raw)
In-Reply-To: <20050504094530.GM8647@rhum.iomeda.fr>
[-- Attachment #1: Type: text/plain, Size: 774 bytes --]
On 04/05/05 11:45 +0200, Christophe Lucas wrote:
> description:
> Use set_current_state() instead of direct assignment of
> current->state.
>
> Signed-off-by: Christophe Lucas <clucas@rotomalug.org>
> diff -urpNX dontdiff a/drivers/block/paride/pcd.c b/drivers/block/paride/pcd.c
> --- a/drivers/block/paride/pcd.c 2005-04-21 02:03:13.000000000 +0200
> +++ b/drivers/block/paride/pcd.c 2005-04-29 09:53:18.000000000 +0200
> @@ -516,7 +516,7 @@ static int pcd_tray_move(struct cdrom_de
>
> static void pcd_sleep(int cs)
> {
> - current->state = TASK_INTERRUPTIBLE;
> + set_current_state(TASK_INTERRUPTIBLE);
> schedule_timeout(cs);
nacc already did these (at least paride ones seem to be in -kj) in IMHO
more correct way: converted *_sleep calls to msleep.
Domen
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
prev parent reply other threads:[~2005-05-05 17:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-04 9:45 [KJ] [PATCH] drivers/block/paride/pcd.c : replace direct assignment Christophe Lucas
2005-05-05 17:20 ` Domen Puncer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050505172037.GC3917@nd47.coderock.org \
--to=domen@coderock.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.