[KJ] [PATCH] drivers/block/paride/pcd.c : replace direct assignment

[KJ] [PATCH] drivers/block/paride/pcd.c : replace direct assignment

[Christophe Lucas]

[-- Attachment #1: Type: text/plain, Size: 141 bytes --]

description:
Use set_current_state() instead of direct assignment of
current->state.

Signed-off-by: Christophe Lucas <clucas@rotomalug.org>

[-- Attachment #2: linux-2.6.12-rc3_drivers_block_paride_pcd.c.patch --]
[-- Type: text/plain, Size: 423 bytes --]

diff -urpNX dontdiff a/drivers/block/paride/pcd.c b/drivers/block/paride/pcd.c
--- a/drivers/block/paride/pcd.c	2005-04-21 02:03:13.000000000 +0200
+++ b/drivers/block/paride/pcd.c	2005-04-29 09:53:18.000000000 +0200
@@ -516,7 +516,7 @@ static int pcd_tray_move(struct cdrom_de
 
 static void pcd_sleep(int cs)
 {
-	current->state = TASK_INTERRUPTIBLE;
+	set_current_state(TASK_INTERRUPTIBLE);
 	schedule_timeout(cs);
 }
 

[-- Attachment #3: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] drivers/block/paride/pcd.c : replace direct

[Domen Puncer]

[-- Attachment #1: Type: text/plain, Size: 774 bytes --]

On 04/05/05 11:45 +0200, Christophe Lucas wrote:
> description:
> Use set_current_state() instead of direct assignment of
> current->state.
> 
> Signed-off-by: Christophe Lucas <clucas@rotomalug.org>

> diff -urpNX dontdiff a/drivers/block/paride/pcd.c b/drivers/block/paride/pcd.c
> --- a/drivers/block/paride/pcd.c	2005-04-21 02:03:13.000000000 +0200
> +++ b/drivers/block/paride/pcd.c	2005-04-29 09:53:18.000000000 +0200
> @@ -516,7 +516,7 @@ static int pcd_tray_move(struct cdrom_de
>  
>  static void pcd_sleep(int cs)
>  {
> -	current->state = TASK_INTERRUPTIBLE;
> +	set_current_state(TASK_INTERRUPTIBLE);
>  	schedule_timeout(cs);

nacc already did these (at least paride ones seem to be in -kj) in IMHO
more correct way: converted *_sleep calls to msleep.


	Domen

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors