All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <michael@ellerman.id.au>
To: Linux Kernel list <linux-kernel@vger.kernel.org>
Cc: Adrian Bunk <bunk@stusta.de>, Andrew Morton <akpm@osdl.org>
Subject: [2.6 patch] drivers/block/rd.c: don't make a variable static
Date: Fri, 6 May 2005 19:48:31 +1000	[thread overview]
Message-ID: <200505061948.31332.michael@ellerman.id.au> (raw)
In-Reply-To: <20050502014719.GE3592@stusta.de>

On Mon, 2 May 2005 11:47, Adrian Bunk wrote:
> This patch makes a needlessly global variable static.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.12-rc2-mm2-full/drivers/block/rd.c.old	2005-04-10
> 02:00:08.000000000 +0200 +++
> linux-2.6.12-rc2-mm2-full/drivers/block/rd.c	2005-04-10 02:01:00.000000000
> +0200 @@ -74,7 +74,7 @@
>   * architecture-specific setup routine (from the stored boot sector
>   * information).
>   */
> -int rd_size = CONFIG_BLK_DEV_RAM_SIZE;		/* Size of the RAM disks */
> +static int rd_size = CONFIG_BLK_DEV_RAM_SIZE;	/* Size of the RAM disks */
>  /*
>   * It would be very desirable to have a soft-blocksize (that in the case
>   * of the ramdisk driver is also the hardblocksize ;) of PAGE_SIZE because


This patch breaks PPC iSeries in arch/ppc64/kernel/iSeries_setup.c


--- veth-fixes/drivers/block/rd.c	2005-05-06 19:26:53.000000000 +1000
+++ 2.6.12-rc3/drivers/block/rd.c	2005-04-29 15:14:23.000000000 +1000
@@ -74,7 +74,7 @@
  * architecture-specific setup routine (from the stored boot sector
  * information).
  */
-static int rd_size = CONFIG_BLK_DEV_RAM_SIZE;	/* Size of the RAM disks */
+int rd_size = CONFIG_BLK_DEV_RAM_SIZE;		/* Size of the RAM disks */
 /*
  * It would be very desirable to have a soft-blocksize (that in the case
  * of the ramdisk driver is also the hardblocksize ;) of PAGE_SIZE because

      reply	other threads:[~2005-05-06  9:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-02  1:47 [2.6 patch] drivers/block/rd.c: make a variable static Adrian Bunk
2005-05-06  9:48 ` Michael Ellerman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200505061948.31332.michael@ellerman.id.au \
    --to=michael@ellerman.id.au \
    --cc=akpm@osdl.org \
    --cc=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.