From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261263AbVEFVUd (ORCPT ); Fri, 6 May 2005 17:20:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261260AbVEFVU3 (ORCPT ); Fri, 6 May 2005 17:20:29 -0400 Received: from mailout.stusta.mhn.de ([141.84.69.5]:49157 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S261249AbVEFVT1 (ORCPT ); Fri, 6 May 2005 17:19:27 -0400 Date: Fri, 6 May 2005 23:19:14 +0200 From: Adrian Bunk To: Andrew Morton Cc: ak@suse.de, linux-kernel@vger.kernel.org Subject: [2.6 patch] unexport phys_proc_id and cpu_core_id Message-ID: <20050506211913.GO3590@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Back in January, Andi Kleen added EXPORT_SYMBOL(phys_proc_id), stating: This is needed for the powernow k8 driver to manage AMD dual core systems. This EXPORT_SYMBOL was never used. I asked him on 13 Mar 2005 whether it's really required, but he didn't answer to my email. 2.6.12-rc3 adds cpu_core_id with a similarly unused EXPORT_SYMBOL(cpu_core_id). It's OK to export symbols when these exports are required, but unless someone can explain why they are required now, they should be removed before 2.6.12 and then re-added when they are actually used. Signed-off-by: Adrian Bunk --- arch/i386/kernel/smpboot.c | 2 -- arch/x86_64/kernel/smpboot.c | 2 -- 2 files changed, 4 deletions(-) --- linux-2.6.12-rc3-mm3-full/arch/i386/kernel/smpboot.c.old 2005-05-06 22:58:29.000000000 +0200 +++ linux-2.6.12-rc3-mm3-full/arch/i386/kernel/smpboot.c 2005-05-06 22:58:47.000000000 +0200 @@ -67,12 +67,10 @@ /* Package ID of each logical CPU */ int phys_proc_id[NR_CPUS] __cacheline_aligned_mostly_readonly = {[0 ... NR_CPUS-1] = BAD_APICID}; -EXPORT_SYMBOL(phys_proc_id); /* Core ID of each logical CPU */ int cpu_core_id[NR_CPUS] __cacheline_aligned_mostly_readonly = {[0 ... NR_CPUS-1] = BAD_APICID}; -EXPORT_SYMBOL(cpu_core_id); cpumask_t cpu_sibling_map[NR_CPUS] __cacheline_aligned_mostly_readonly; cpumask_t cpu_core_map[NR_CPUS] __cacheline_aligned_mostly_readonly; --- linux-2.6.12-rc3-mm3-full/arch/x86_64/kernel/smpboot.c.old 2005-05-06 22:59:01.000000000 +0200 +++ linux-2.6.12-rc3-mm3-full/arch/x86_64/kernel/smpboot.c 2005-05-06 22:59:12.000000000 +0200 @@ -67,8 +67,6 @@ /* Package ID of each logical CPU */ u8 phys_proc_id[NR_CPUS] = { [0 ... NR_CPUS-1] = BAD_APICID }; u8 cpu_core_id[NR_CPUS] = { [0 ... NR_CPUS-1] = BAD_APICID }; -EXPORT_SYMBOL(phys_proc_id); -EXPORT_SYMBOL(cpu_core_id); /* Bitmask of currently online CPUs */ cpumask_t cpu_online_map;