All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Natalie.Protasevich@unisys.com
Cc: akpm@osdl.org, ak@suse.de, zwane@arm.linux.org.uk,
	len.brown@intel.com, venkatesh.pallipadi@intel.com,
	linux-kernel@vger.kernel.org
Subject: Re: [patch 1/1] Do not enforce unique IO_APIC_ID for Xeon processors in EM64T mode (x86_64)
Date: Sat, 7 May 2005 15:41:16 +0200	[thread overview]
Message-ID: <20050507134116.GA30158@wotan.suse.de> (raw)
In-Reply-To: <20050505221117.508BB42AE4@linux.site>

On Thu, May 05, 2005 at 03:11:16PM -0700, Natalie.Protasevich@unisys.com wrote:
> 
> 
> This patch disables unique IO_APIC_ID check for xAPIC systems running in EM64T mode. Xeon-based ES7000s panic failing this unnecessary check. I added IOAPIC_ID_CHECK config option and turned it off for Intel processors. Also added the boot option that overrides default and turnes this check on/off in case it is needed for some reason. Hope this is acceptable way to fix the problem.

I think we can turn it off for all x86-64 systems. Near all EM64T 
systems have xAPIC. AMD processors don't need it neither. That would only 
leave the new IBM summit2 chipset, but I suppose they also don't need this 
(James please complain if I am wrong)

So can you please do a new patch that just removes this code?

More tricky will be to do the equivalent patch on i386 because they
still need to support the pre XAPICs and have to detect this case.
I suppose an heuristic like
if (cpu is P6 or earlier and from Intel)
	enable
else
	disable
would be good enough.	

Thanks

-Andi


  parent reply	other threads:[~2005-05-07 13:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-05 22:11 [patch 1/1] Do not enforce unique IO_APIC_ID for Xeon processors in EM64T mode (x86_64) Natalie.Protasevich
2005-05-06 17:34 ` Len Brown
2005-05-06 17:57 ` Zwane Mwaikambo
2005-05-07 13:41 ` Andi Kleen [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-05-07  5:34 Natalie.Protasevich
2005-05-08  1:00 ` Zwane Mwaikambo
2005-05-08  5:01 Protasevich, Natalie
2005-05-08 13:49 ` Andi Kleen
2005-05-09 19:15   ` James Cleverdon
2005-05-08 17:28 Protasevich, Natalie
2005-05-08 23:53 ` Andi Kleen
2005-05-11  7:10 Protasevich, Natalie
2005-05-11 11:22 ` Andi Kleen
2005-05-11 16:21 Protasevich, Natalie
2005-05-11 19:22 ` Andi Kleen
2005-05-12  2:22 Protasevich, Natalie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050507134116.GA30158@wotan.suse.de \
    --to=ak@suse.de \
    --cc=Natalie.Protasevich@unisys.com \
    --cc=akpm@osdl.org \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=venkatesh.pallipadi@intel.com \
    --cc=zwane@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.