From: Jonas Fonseca <fonseca@diku.dk>
To: Sean <seanlkml@sympatico.ca>
Cc: Petr Baudis <pasky@ucw.cz>, GIT Mailing List <git@vger.kernel.org>
Subject: Re: cg-log patches
Date: Mon, 9 May 2005 01:49:36 +0200 [thread overview]
Message-ID: <20050508234936.GA26624@diku.dk> (raw)
In-Reply-To: <1742.10.10.10.24.1115573750.squirrel@linux1>
Sean <seanlkml@sympatico.ca> wrote Sun, May 08, 2005:
> commit 33762f33ee87377c0cfcea51382bad04d7c9ba8d
>
> Fix cg-log -f option so that a complete list of files is
> displayed when a commit has more than one parent.
This sounds great.
> Move the list of files so they're displayed after the
> commit message
The reason I put it at the top was to make it more similar to GNU-style
changelogs (if there is such a style).
> List the files in columns, instead of one big line of comma-
> separated files.
I think that will make `-f' less usable because of the extra scrolling.
Assuming use of wc will not create more dependency nightmares and the
extra overhead is acceptable here is a patch that will wrap file listing
lines near the 80th column.
Signed-off-by: Jonas Fonseca <fonseca@diku.dk>
--- d4119364a7fbf5a4b8f00f061e4f5d58fa4abd0e/cg-log (mode:100755)
+++ uncommitted/cg-log (mode:100755)
@@ -64,8 +64,16 @@
fi
echo
$list_cmd | while read modes type sha1s file; do
- echo -n "$sep$file"
+ echo -n "$sep"
sep=", "
+ if [ $(echo "$line$sep$file" | wc -c) -lt 75 ]; then
+ line="$line$sep$file"
+ echo -n "$file"
+ else
+ line="$file"
+ echo "$coldefault"
+ echo -n " $colfiles$file"
+ fi
done
echo "$coldefault:"
}
--
Jonas Fonseca
next prev parent reply other threads:[~2005-05-08 23:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-08 17:35 cg-log patches Sean
2005-05-08 17:42 ` Marcel Holtmann
2005-05-08 18:26 ` Sean
2005-05-08 19:00 ` Marcel Holtmann
2005-05-08 19:18 ` Petr Baudis
2005-05-08 19:23 ` Sean
2005-05-08 19:25 ` Petr Baudis
2005-05-08 19:52 ` Sean
2005-05-08 19:27 ` Marcel Holtmann
[not found] ` <1792.10.10.10.24.1115575196.squirrel@linux1>
[not found] ` <20050508180312.GB9495@pasky.ji.cz>
[not found] ` <1896.10.10.10.24.1115577733.squirrel@linux1>
2005-05-08 19:01 ` Petr Baudis
2005-05-08 23:49 ` Jonas Fonseca [this message]
2005-05-09 3:45 ` Sean
2005-05-09 11:39 ` Jonas Fonseca
2005-05-09 12:14 ` Petr Baudis
2005-05-09 12:41 ` Jonas Fonseca
2005-05-09 13:13 ` Sean
2005-05-10 0:37 ` Petr Baudis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050508234936.GA26624@diku.dk \
--to=fonseca@diku.dk \
--cc=git@vger.kernel.org \
--cc=pasky@ucw.cz \
--cc=seanlkml@sympatico.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.