From: Andi Kleen <ak@muc.de>
To: Mikael Pettersson <mikpe@csd.uu.se>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.12-rc3-mm3] perfctr: x86 update with K8 multicore fixes
Date: 9 May 2005 03:38:51 +0200
Date: Mon, 9 May 2005 03:38:51 +0200 [thread overview]
Message-ID: <20050509013851.GA54090@muc.de> (raw)
In-Reply-To: <200505090040.j490e19v012839@harpo.it.uu.se>
On Mon, May 09, 2005 at 02:40:01AM +0200, Mikael Pettersson wrote:
> > How about you just check cpu_core_map[] instead of adding your
> > own custom detection code for this? This seems quite bogus to me.
>
> Because these <whatever>map[]s are poorly documented, change
> (get added or removed), and don't always exist in all subarchs.
That's all not true.
> I've been burned by cpu-related maps changing before. I'd rather
> not rely on them if I can avoid them.
I don't think that's a good attitude for a in tree driver.
If all drivers reimplemented core architecture features
all the time we would have a big mess. So please don't do
this.
-Andi
next prev parent reply other threads:[~2005-05-09 1:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-09 0:40 [PATCH 2.6.12-rc3-mm3] perfctr: x86 update with K8 multicore fixes Mikael Pettersson
2005-05-09 1:38 ` Andi Kleen [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-05-09 8:53 Mikael Pettersson
2005-05-08 18:45 Mikael Pettersson
2005-05-08 23:37 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050509013851.GA54090@muc.de \
--to=ak@muc.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@csd.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.