From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: [RFC PATCH 2.6.12-rc3] dynamic driver sysfs callbacks and RFC
Date: Thu, 19 May 2005 06:25:57 +0000 [thread overview]
Message-ID: <20050509213403.2f0ea0a5.khali@linux-fr.org> (raw)
In-Reply-To: <2538186705042422366584aff4@mail.gmail.com>
Hi Yani,
> With respect to the lm_sensors chip drivers an int alone might make
> sense (although for bmcsensors the void* is better), but when you
> start looking at the rest of the kernel code that uses attributes the
> void * looks like a very good decision.
>
> If you have a look at my patch for net-sysfs.c for example, its hard
> (impossible?) to imagine a way to do a similar thing with just an int
> being passed to the callbacks, and this is using static attributes.
You could always define a static array of pointers, and use the passed
int as an index to that array, thus converting the int into a pointer.
It's not very different from defining a static array of ints and passing
the int addresses as the void*, but for some reason I tend to prefer the
int -> pointer conversion (most certainly because my view if awfully
biased by my misknowledge of the kernel except for the i2c and hardware
monitoring code).
> Yes, it is starting to look like the cold hand of a dictator might be
> needed ... where is Greg anyway ;-)?
Don't blame him, I am wasting his time over IRC, this is why... ;)
--
Jean Delvare
next prev parent reply other threads:[~2005-05-19 6:25 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-19 6:25 [RFC PATCH 2.6.12-rc3] dynamic driver sysfs callbacks and RFC on Yani Ioannou
2005-05-19 6:25 ` Greg KH
2005-05-19 6:25 ` Grant Coady
2005-05-19 6:25 ` Dmitry Torokhov
2005-05-19 6:25 ` Dmitry Torokhov
2005-05-19 6:25 ` Jean Delvare
2005-05-19 6:25 ` Dmitry Torokhov
2005-05-19 6:25 ` Yani Ioannou
2005-05-19 6:25 ` Yani Ioannou
2005-05-19 6:25 ` Greg KH
2005-05-19 6:25 ` Greg KH
2005-05-19 6:25 ` Jean Delvare
2005-05-19 6:25 ` Yani Ioannou
2005-05-19 6:25 ` Greg KH
2005-05-19 6:25 ` Greg KH
2005-05-19 6:25 ` Greg KH
2005-05-19 6:25 ` Greg KH
2005-05-19 6:25 ` Yani Ioannou
2005-05-19 6:25 ` Yani Ioannou
2005-05-19 6:25 ` Yani Ioannou
2005-05-19 6:25 ` Grant Coady
2005-05-19 6:25 ` Yani Ioannou
2005-05-19 6:25 ` Dmitry Torokhov
2005-05-19 6:25 ` Greg KH
2005-05-19 6:25 ` Grant Coady
2005-05-19 6:25 ` Greg KH
2005-05-19 6:25 ` Greg KH
2005-05-19 6:25 ` Greg KH
2005-05-19 6:25 ` Yani Ioannou
2005-05-19 6:25 ` Yani Ioannou
2005-05-19 6:25 ` Jean Delvare
2005-05-19 6:25 ` Yani Ioannou
2005-05-19 6:25 ` Jean Delvare [this message]
2005-05-19 6:25 ` Yani Ioannou
2005-05-19 6:25 ` Yani Ioannou
2005-05-19 6:25 ` Dmitry Torokhov
2005-05-19 6:25 ` Dmitry Torokhov
2005-05-19 6:25 ` Yani Ioannou
2005-05-19 6:25 ` Yani Ioannou
2005-05-19 6:25 ` Jean Delvare
2005-05-19 6:25 ` Yani Ioannou
2005-05-19 6:25 ` Yani Ioannou
2005-05-19 6:25 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050509213403.2f0ea0a5.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.