All of lore.kernel.org
 help / color / mirror / Atom feed
From: greg@kroah.com (Greg KH)
To: lm-sensors@vger.kernel.org
Subject: [PATCH] ALI1563 SMBus driver fix - take 2
Date: Thu, 19 May 2005 06:25:57 +0000	[thread overview]
Message-ID: <20050509231217.GA24157@kroah.com> (raw)
In-Reply-To: <20050421090756.13436.qmail@desitka.sh.cvut.cz>

On Sun, May 08, 2005 at 02:57:37PM +0200, Jean Delvare wrote:
> Hi Greg, Rudolf,
> 
> > Please can my patch go to 2.6.12? It is quite critical bug fix.
> > Without the fixes driver is simply unusable.
> > 
> > 1) It wont work with newer revisions
> > 2) It would not work even with older because i2c transaction size mask
> > is missing. That means if you use eeprom driver and sensor driver you
> > wont get any data. I mean data that would make sense.The missing mask
> > would trigger some WORD modes...
> > 
> > 3) eeprom reading wont work because command type goes to DAT0 and not
> > to CMD.
> > 
> > So whole patch is needed to address all "grave" issues.
> 
> I'd second Rudolf's request. This patch would be really welcome into
> 2.6.12, without it the i2c-ali1563 driver is plain broken and will most
> probably generate lots of support requests.

Ok, I've moved it up to my "before 2.6.12 is out" set of patches to be
sent out.

thanks,

greg k-h

  parent reply	other threads:[~2005-05-19  6:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-19  6:25 [PATCH] ALI1563 SMBus driver fix - take 2 R.Marek
2005-05-19  6:25 ` Greg KH
2005-05-19  6:25 ` Greg KH [this message]
2005-05-19  6:25 ` Jean Delvare
2005-05-19  6:25 ` Rudolf Marek
2005-05-28 10:11 ` [lm-sensors] " Rudolf Marek
2005-06-02  0:48 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050509231217.GA24157@kroah.com \
    --to=greg@kroah.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.