From: Matt Porter <mporter@kernel.crashing.org>
To: Dan Malek <dan@embeddededge.com>
Cc: Tom Rini <trini@kernel.crashing.org>,
linuxppc-embedded <linuxppc-embedded@ozlabs.org>
Subject: Re: [PATCH 03/04] Freescale Ethernet combined driver
Date: Tue, 10 May 2005 06:27:44 -0700 [thread overview]
Message-ID: <20050510062744.A21835@cox.net> (raw)
In-Reply-To: <f1e15a8d9ed033e850b56ca965754a43@embeddededge.com>; from dan@embeddededge.com on Tue, May 10, 2005 at 08:13:48AM -0400
On Tue, May 10, 2005 at 08:13:48AM -0400, Dan Malek wrote:
>
> On May 10, 2005, at 7:17 AM, Pantelis Antoniou wrote:
>
> > This patch replace iopa use with virt_to_phys.
>
> Not gonna work .....
>
> When you map uncached on 8xx you get a new vmalloc()
> space. The virt_to_xxx macros don't work on those addresses.
> You need to use the dma_consistent() function, stash the
> real physical address it returns and then use it where
> appropriate.
That and the use of virt_to_* and friends is deprecated by
the DMA API. You'll never get that upstream even if it were
a case where it did work. That's a good thing to know for
anybody doing other drivers...
-Matt
next prev parent reply other threads:[~2005-05-10 13:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-09 11:45 [PATCH 03/04] Freescale Ethernet combined driver Pantelis Antoniou
2005-05-09 20:38 ` Matt Porter
2005-05-10 11:17 ` Pantelis Antoniou
2005-05-10 12:13 ` Dan Malek
2005-05-10 12:15 ` Pantelis Antoniou
2005-05-10 13:27 ` Matt Porter [this message]
2005-05-10 13:14 ` Pantelis Antoniou
2005-05-10 13:47 ` Matt Porter
2005-05-10 13:36 ` Pantelis Antoniou
2005-05-12 9:37 ` Pantelis Antoniou
2005-05-13 8:51 ` Pantelis Antoniou
2005-05-10 18:14 ` Dan Malek
-- strict thread matches above, loose matches on Subject: below --
2005-05-10 14:53 Rune Torgersen
2005-05-10 18:24 ` Dan Malek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050510062744.A21835@cox.net \
--to=mporter@kernel.crashing.org \
--cc=dan@embeddededge.com \
--cc=linuxppc-embedded@ozlabs.org \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.