All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Abhay Salunke <Abhay_Salunke@dell.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
	matt_domsch@dell.com
Subject: Re: [patch 2.6.12-rc3] dell_rbu: New Dell BIOS update driver
Date: Wed, 11 May 2005 00:19:02 -0700	[thread overview]
Message-ID: <20050511071902.GA10352@kroah.com> (raw)
In-Reply-To: <20050510220520.GA30741@littleblue.us.dell.com>

On Tue, May 10, 2005 at 05:05:20PM -0500, Abhay Salunke wrote:
> +static struct bin_attribute rbudata_attr = {
> +	.attr = {.name = "rbudata", .owner = THIS_MODULE, .mode = 0644},
> +	.read = read_rbu_data,
> +	.write = write_rbu_data,
> +};
> +
> +static struct bin_attribute rbudatasize_attr = {
> +	.attr = { .name = "rbudatasize", .owner = THIS_MODULE, .mode = 0644 },
> +	.read = read_rbu_data_size,
> +	.write= write_rbu_data_size,
> +};
> +
> +static struct bin_attribute packetdatasize_attr = {
> +	.attr = { .name = "packetdatasize", .owner = THIS_MODULE, .mode = 0644 },
> +	.read = read_packet_data_size,
> +	.write= write_packet_data_size,
> +};
> +
> +static struct bin_attribute packetdata_attr = {
> +	.attr = { .name = "packetdata", .owner = THIS_MODULE, .mode = 0644 },
> +	.read = read_rbu_packet_data,
> +	.write= write_rbu_packet_data,
> +};

I can understand having the data use the sysfs binary attribute, but do
not do this for the size files.  Please just use a normal attribute for
them, the binary ones are _only_ for blobs of data that are not
interpreted by the kernel.

thanks,

greg k-h

  parent reply	other threads:[~2005-05-11  7:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-10 22:05 [patch 2.6.12-rc3] dell_rbu: New Dell BIOS update driver Abhay Salunke
2005-05-10 23:59 ` Andrew Morton
2005-05-11  8:35   ` Arjan van de Ven
2005-05-11  7:19 ` Greg KH [this message]
2005-05-11  8:49 ` Arjan van de Ven
2005-05-11  9:57 ` Xavier Bestel
2005-05-11 22:05 ` Matt Domsch
  -- strict thread matches above, loose matches on Subject: below --
2005-05-11 15:25 Abhay_Salunke
2005-05-11 18:21 Abhay_Salunke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050511071902.GA10352@kroah.com \
    --to=greg@kroah.com \
    --cc=Abhay_Salunke@dell.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt_domsch@dell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.