From: Max Kellermann <max@duempel.org>
To: netfilter-devel@lists.netfilter.org
Cc: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Subject: Re: [PATCH pom-ng 2/3] h323-conntrack-nat updates: q931_find_u2u() returns relative length
Date: Thu, 12 May 2005 22:53:05 +0200 [thread overview]
Message-ID: <20050512205305.GE2175@roonstrasse.net> (raw)
In-Reply-To: <20050512205206.GC2175@roonstrasse.net>
[-- Attachment #1: Type: text/plain, Size: 230 bytes --]
On 2005/05/12 22:52, Max Kellermann <max@duempel.org> wrote:
> h323-02-u2u_length_is_relative.patch
> - minor bugfix, never occurred in reality
> - length returned by q931_find_u2u() is relative
>
sorry, I'll never learn... ;)
[-- Attachment #2: h323-02-u2u_length_is_relative.patch --]
[-- Type: text/plain, Size: 1057 bytes --]
Thu May 12 22:21:24 CEST 2005 max@duempel.org
* length returned by q931_find_u2u() is relative
diff -rN -u old-h323-0/h323-conntrack-nat/linux-2.6.11/net/ipv4/netfilter/ip_conntrack_h323_h225.c new-h323-0/h323-conntrack-nat/linux-2.6.11/net/ipv4/netfilter/ip_conntrack_h323_h225.c
--- old-h323-0/h323-conntrack-nat/linux-2.6.11/net/ipv4/netfilter/ip_conntrack_h323_h225.c 2005-05-12 22:48:51.000000000 +0200
+++ new-h323-0/h323-conntrack-nat/linux-2.6.11/net/ipv4/netfilter/ip_conntrack_h323_h225.c 2005-05-12 22:48:51.000000000 +0200
@@ -214,9 +214,7 @@
{
struct asn1_per_buffer bb;
- /* protocol(1) + header(3) + protocolIdentifier(6) +
- h245ipAddress(1) + h245ipv4(4) + h245ipv4port(2) */
- if (length < 17)
+ if (i + 8 > length)
return NF_ACCEPT;
if (data[i++] != 0x05) /* X.208 / X.209 */
@@ -297,6 +295,10 @@
if (i == 0)
return NF_ACCEPT;
+ /* the length returned by q931_find_u2u() is relative
+ to i */
+ length += i;
+
return h225_parse_q931_connect(pskb, ct, ctinfo,
data, i, length);
} else {
next prev parent reply other threads:[~2005-05-12 20:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-12 20:49 [PATCH pom-ng 0/3] h323-conntrack-nat updates: buffer checks Max Kellermann
2005-05-12 20:50 ` [PATCH pom-ng 1/3] h323-conntrack-nat updates: check bb->error in every iteration Max Kellermann
2005-05-12 20:51 ` Max Kellermann
2005-05-12 20:52 ` [PATCH pom-ng 2/3] h323-conntrack-nat updates: q931_find_u2u() returns relative length Max Kellermann
2005-05-12 20:53 ` Max Kellermann [this message]
2005-05-12 20:52 ` [PATCH pom-ng 3/3] h323-conntrack-nat updates: simplified length checks Max Kellermann
2005-05-17 15:32 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050512205305.GE2175@roonstrasse.net \
--to=max@duempel.org \
--cc=kadlec@blackhole.kfki.hu \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.