From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] Fwd: qemu-arm : additional fix around QSUB maybe need
Date: Sat, 14 May 2005 02:29:45 +0100 [thread overview]
Message-ID: <200505140229.45764.paul@codesourcery.com> (raw)
---------- Forwarded Message ----------
Subject: qemu-arm : additional fix around QSUB maybe need
Date: Saturday 14 May 2005 02:26
From: "TAKAGO Daisuke" <takago1129@hotmail.com>
To: paul@codesourcery.com
Dear Paul Brook
Hello!
Thank very much for sending fix-patch to me quickly!!
I noticed that patch applyed to CVS. Then I built qemu-arm from CVS.
I tested saturating instructions(QADD, QSUB).
QADD could execute saturating instruction, but QSUB cound not.
I found the problem points in op_subl_T0_T1_saturate().
The following is a fix point I think.
----- qemu/op.c (near line 797)
void OPPROTO op_subl_T0_T1_saturate(void)
{
uint32_t res;
res = T0 - T1;
if (((res ^ T0) & SIGNBIT) && ((T0 ^ T1) & SIGNBIT)) {
env->QF = 1;
if (T0 & SIGNBIT)
- T0 = 0x8000000;
+ T0 = 0x80000000;
else
T0 = 0x7fffffff;
}
else
T0 = res;
FORCE_RET();
}
--------------------------------------
reply other threads:[~2005-05-14 1:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200505140229.45764.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.