From: Andi Kleen <ak@suse.de>
To: Hugh Dickins <hugh@veritas.com>
Cc: Andrew Morton <akpm@osdl.org>, "Yu, Luming" <luming.yu@intel.com>,
"Guo, Racing" <racing.guo@intel.com>, Andi Kleen <ak@suse.de>,
Dave Jones <davej@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] x86 port lockless MCE quirky bank0
Date: Tue, 17 May 2005 22:24:28 +0200 [thread overview]
Message-ID: <20050517202428.GD307@wotan.suse.de> (raw)
In-Reply-To: <Pine.LNX.4.61.0505172107490.5585@goblin.wat.veritas.com>
> + if ((c->x86_vendor == X86_VENDOR_AMD ||
> + c->x86_vendor == X86_VENDOR_INTEL) && c->x86 == 6) {
> + /*
> + * Intel P6 cores go bang quickly when bank0 is enabled.
> + * Some Athlons cause spurious MCEs when bank0 is enabled.
> + */
> + quirky_bank0 = 1;
> + }
That's wrong on K8 AMD machines at least. You need to check c->x86
there too.
And better would be to just do bank[0] = 0 instead of
adding the new variable.
-Andi
P.S.: Also Yu Luming can you please submit an updated patch that keeps mce.c
in arch/x86_64 like we discussed earlier?
next prev parent reply other threads:[~2005-05-17 20:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-17 20:18 [PATCH -mm] x86 port lockless MCE quirky bank0 Hugh Dickins
2005-05-17 20:24 ` Andi Kleen [this message]
2005-05-17 22:39 ` Andrew Morton
2005-05-18 12:34 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050517202428.GD307@wotan.suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=davej@redhat.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luming.yu@intel.com \
--cc=racing.guo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.