All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: James Bottomley <jejb@steeleye.com>
Cc: Christoph Hellwig <hch@lst.de>,
	SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] aic7xxx: user scsi_device host private data
Date: Mon, 23 May 2005 21:16:29 +0200	[thread overview]
Message-ID: <20050523191629.GA8365@lst.de> (raw)
In-Reply-To: <1116862481.5021.6.camel@mulgrave>

On Mon, May 23, 2005 at 10:34:41AM -0500, James Bottomley wrote:
> On Mon, 2005-05-23 at 17:14 +0200, Christoph Hellwig wrote:
> > -	BUG_ON(dev == NULL);
> 
> Leave that one, just in case ... I think it's completely impossible now,
> but I'm still suspicious of the aic untagged queues and whether they can
> spit back a command.

This doesn't make sense as we never reset the hostdata, so this is a
real can't happen.

> > -	BUG_ON(dev->active);
> 
> Ditto this one .. although I'm less sanguine that this won't be tripped.

this makes a tiny little bit more sense to keep


  reply	other threads:[~2005-05-23 19:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-23 15:14 [PATCH] aic7xxx: user scsi_device host private data Christoph Hellwig
2005-05-23 15:34 ` James Bottomley
2005-05-23 19:16   ` Christoph Hellwig [this message]
2005-05-23 20:04     ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050523191629.GA8365@lst.de \
    --to=hch@lst.de \
    --cc=jejb@steeleye.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.