From: Gerd Knorr <kraxel@suse.de>
To: Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
video4linux list <video4linux-list@redhat.com>
Subject: [patch] v4l: bttv i2c oops fix
Date: Tue, 24 May 2005 14:17:47 +0200 [thread overview]
Message-ID: <20050524121747.GA9440@bytesex> (raw)
Don't try to access the i2c bus if the register wasn't successful.
Signed-off-by: Gerd Knorr <kraxel@suse.de>
---
drivers/media/video/bttv-i2c.c | 3 +++
1 files changed, 3 insertions(+)
Index: linux-2.6.12-rc3/drivers/media/video/bttv-i2c.c
===================================================================
--- linux-2.6.12-rc3.orig/drivers/media/video/bttv-i2c.c 2005-04-26 12:18:56.000000000 +0200
+++ linux-2.6.12-rc3/drivers/media/video/bttv-i2c.c 2005-05-24 14:17:01.000000000 +0200
@@ -365,6 +365,9 @@ int bttv_I2CWrite(struct bttv *btv, unsi
/* read EEPROM content */
void __devinit bttv_readee(struct bttv *btv, unsigned char *eedata, int addr)
{
+ memset(eedata, 0, 256);
+ if (0 != btv->i2c_rc)
+ return;
btv->i2c_client.addr = addr >> 1;
tveeprom_read(&btv->i2c_client, eedata, 256);
}
--
-mm seems unusually stable at present.
-- akpm about 2.6.12-rc3-mm3
reply other threads:[~2005-05-24 12:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050524121747.GA9440@bytesex \
--to=kraxel@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.