Re: [KJ] [PATCH V2] Check return code for IBM Olympic /proc entry

[Domen Puncer <domen@coderock.org>]

[-- Attachment #1: Type: text/plain, Size: 1489 bytes --]

On 18/05/05 01:21 -0700, Kirk True wrote:
> The IBM Olympic driver assumes that the call to create_proc_read_entry 
> always succeeds. This patch simply logs appropriately whether in 
> actuality it was created or not.
> 
> This falls under the 'Audit return codes (and handle failure correctly) 
> for create_proc_*()' item on the TODO list. Also added KERN_* constants
> as per Christophe Lucas' recommendation.
> 
>         Signed-off-by: Kirk True <kirk@kirkandsheila.com>
  ^^ please don't

> 
> --- linux-2.6.12-rc4-kj/drivers/net/tokenring/olympic.c	2005-05-17 23:31:14.000000000 -0700
> +++ linux-2.6.12-rc4-kj-debug/drivers/net/tokenring/olympic.c	2005-05-18 01:11:00.000000000 -0700
> @@ -267,11 +267,16 @@ static int __devinit olympic_probe(struc
>  	register_netdev(dev) ; 
>  	printk("Olympic: %s registered as: %s\n",olympic_priv->olympic_card_name,dev->name);
>  	if (olympic_priv->olympic_network_monitor) { /* Must go after register_netdev as we need the device name */ 
> +		struct proc_dir_entry *proc_dir_entry;
>  		char proc_name[20] ; 
>  		strcpy(proc_name,"net/olympic_") ; 
>  		strcat(proc_name,dev->name) ; 
> -		create_proc_read_entry(proc_name,0,NULL,olympic_proc_info,(void *)dev) ; 
> -		printk("Olympic: Network Monitor information: /proc/%s\n",proc_name); 
> +		proc_dir_entry = create_proc_read_entry(proc_name,0,NULL,olympic_proc_info,(void *)dev) ; 

I removed the unneeded (void*) cast (couldn't resist) and trailing
whitespace here.


Thanks,
	Domen

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors