From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Andrew Morton <akpm@osdl.org>, Hugh Dickins <hugh@veritas.com>
Cc: linux-mm@kvack.org
Subject: [PATCH] small valid_swaphandles() optimization
Date: Wed, 25 May 2005 10:42:34 -0300 [thread overview]
Message-ID: <20050525134234.GA16054@logos.cnet> (raw)
Hi Andrew, Hugh,
The following patch, relative to valid_swaphandles(), moves the EOF
check outside validity check loop, saving a few instructions.
--- a/mm/swapfile.c.orig 2005-05-25 15:45:18.000000000 -0300
+++ b/mm/swapfile.c 2005-05-25 16:20:45.000000000 -0300
@@ -1713,11 +1713,12 @@
toff++, i--;
*offset = toff;
+ /* Don't read-ahead past the end of the swap area */
+ if (toff+i >= swapdev->max)
+ i = swapdev->max - toff - 1;
+
swap_device_lock(swapdev);
do {
- /* Don't read-ahead past the end of the swap area */
- if (toff >= swapdev->max)
- break;
/* Don't read in free or bad pages */
if (!swapdev->swap_map[toff])
break;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next reply other threads:[~2005-05-25 13:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-25 13:42 Marcelo Tosatti [this message]
2005-05-26 2:15 ` [PATCH] small valid_swaphandles() optimization Hugh Dickins
2005-05-26 7:05 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050525134234.GA16054@logos.cnet \
--to=marcelo.tosatti@cyclades.com \
--cc=akpm@osdl.org \
--cc=hugh@veritas.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.