All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kay Sievers <kay.sievers@vrfy.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Junio C Hamano <junkio@cox.net>, Git Mailing List <git@vger.kernel.org>
Subject: Re: change of git-diff-tree and symlinks
Date: Wed, 25 May 2005 20:35:46 +0200	[thread overview]
Message-ID: <20050525183546.GA4241@vrfy.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0505251054110.2307@ppc970.osdl.org>

On Wed, May 25, 2005 at 11:08:54AM -0700, Linus Torvalds wrote:
> 
> 
> On Wed, 25 May 2005, Kay Sievers wrote:
> >
> > I'm catching up with gitweb.cgi to parse the changed output. Works fine
> > so far and is really much easier to parse. Here is something that does
> > not work anymore. See the difference between:
> > 
> >    http://www.kernel.org/git/?p=linux/hotplug/udev.git;a=commit;h=49cedafaf893bfe348eb7598227f1a11ae24bfd6
> >    http://ehlo.org/~kay/gitweb.cgi?p=linux/hotplug/udev.git;a=commit;h=49cedafaf893bfe348eb7598227f1a11ae24bfd6
> 
> Yes, the new diff-tree thing doesn't show symlinks.
> 
> The problem seems to be that we just don't have a "status" flag for it. I 
> think we should call it "T" for "Type change" or something, but in the 
> meantime let's just have the rule that instead of ignoring unknown state 
> changes, we always print them out as "?" instead.
> 
> Ie something like this..
> 
> (And I'd suggest you make gitweb flexible enough that it does something 
> sane if it sees an unknown reason code - let's see what Junio thinks about 
> what status code we should use for this).

Ok, works again. Any reason not to mark it as 'M'? It's easyly to
distinguish between a content change and a mode change by looking if
the sha has changed.

Kay

  reply	other threads:[~2005-05-25 18:46 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-25 11:17 change of git-diff-tree and symlinks Kay Sievers
2005-05-25 18:08 ` Linus Torvalds
2005-05-25 18:35   ` Kay Sievers [this message]
2005-05-25 19:40     ` Junio C Hamano
2005-05-25 22:06       ` [PATCH] Adjust show-files test for dotfiles Junio C Hamano
2005-05-25 22:07       ` [PATCH] Fix type-change handling when assigning the status code to filepairs Junio C Hamano
2005-05-25 22:26       ` change of git-diff-tree and symlinks Kay Sievers
2005-05-25 22:43         ` Junio C Hamano
2005-05-25 22:47         ` Linus Torvalds
2005-05-25 23:00           ` [PATCH] Mode only changes from diff Junio C Hamano
2005-05-26  2:11             ` [PATCH] Test case portability fix Junio C Hamano
2005-05-26  2:36               ` Linus Torvalds
2005-05-26  2:55                 ` Junio C Hamano
2005-05-29 14:16 ` change of git-diff-tree and symlinks Jochen Roemling
2005-05-29 15:06   ` Kay Sievers
2005-05-29 16:06     ` Jochen Roemling
2005-05-29 16:14       ` Sebastian Kuzminsky
2005-05-30  3:17       ` Sebastian Kuzminsky
2005-05-29 18:55     ` Junio C Hamano
2005-05-29 21:32     ` Petr Baudis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050525183546.GA4241@vrfy.org \
    --to=kay.sievers@vrfy.org \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.