All of lore.kernel.org
 help / color / mirror / Atom feed
From: Henry <haris@mpa.gr>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] [PATCH] drivers/scsi/gdth.c Use the DMA_32BIT_MASK constant
Date: Sat, 28 May 2005 00:16:51 +0000	[thread overview]
Message-ID: <200505280316.51652.haris@mpa.gr> (raw)

[-- Attachment #1: Type: text/plain, Size: 1647 bytes --]

Hi, this is my first patch for linux kernel. Don't know if its correct, please check. Its based on an item on the 
TODO list


Signed-off-by: Kouzinopoulos Haris <haris at mpa.gr>

--- linux/drivers/scsi/gdth.c	2005-05-28 02:38:23.000000000 +0300
+++ linux/drivers/scsi/gdth.c.patch	2005-05-28 03:02:33.000000000 +0300
@@ -388,6 +388,7 @@
 #include <linux/proc_fs.h>
 #include <linux/time.h>
 #include <linux/timer.h>
+#include <linux/dma-mapping.h>
 #ifdef GDTH_RTC
 #include <linux/mc146818rtc.h>
 #endif
@@ -4529,15 +4530,15 @@ static int __init gdth_detect(Scsi_Host_
             if (!(ha->cache_feat & ha->raw_feat & ha->screen_feat &GDT_64BIT)||
                 /* 64-bit DMA only supported from FW >= x.43 */
                 (!ha->dma64_support)) {
-                if (pci_set_dma_mask(pcistr[ctr].pdev, 0xffffffff)) {
+                if (pci_set_dma_mask(pcistr[ctr].pdev, DMA_32BIT_MASK)) {
                     printk(KERN_WARNING "GDT-PCI %d: Unable to set 32-bit DMA\n", hanum);
                     err = TRUE;
                 }
             } else {
                 shp->max_cmd_len = 16;
-                if (!pci_set_dma_mask(pcistr[ctr].pdev, 0xffffffffffffffffULL)) {
+                if (!pci_set_dma_mask(pcistr[ctr].pdev, DMA_32BIT_MASK)) {
                     printk("GDT-PCI %d: 64-bit DMA enabled\n", hanum);
-                } else if (pci_set_dma_mask(pcistr[ctr].pdev, 0xffffffff)) {
+                } else if (pci_set_dma_mask(pcistr[ctr].pdev, DMA_32BIT_MASK)) {
                     printk(KERN_WARNING "GDT-PCI %d: Unable to set 64/32-bit DMA\n", hanum);
                     err = TRUE;
                 }

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

             reply	other threads:[~2005-05-28  0:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-28  0:16 Henry [this message]
2005-05-28  0:24 ` [KJ] [PATCH] drivers/scsi/gdth.c Use the DMA_32BIT_MASK constant Dave Jones
2005-05-28  7:34 ` Tobias Klauser
2005-05-28 12:07 ` Henry
2005-05-29  9:30 ` Christophe Lucas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200505280316.51652.haris@mpa.gr \
    --to=haris@mpa.gr \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.