All of lore.kernel.org
 help / color / mirror / Atom feed
From: domen@coderock.org
To: viro@parcelfarce.linux.theplanet.co.uk
Cc: linux-fsdevel@vger.kernel.org, Jesse Millan <jessem@cs.pdx.edu>,
	domen@coderock.org
Subject: [patch 1/2] Fix gcc4 warning, file & fd may be used uninitialized in this function
Date: Sun, 29 May 2005 01:17:13 +0200	[thread overview]
Message-ID: <20050528231712.778427000@nd47.coderock.org> (raw)

[-- Attachment #1: warning-fs_eventpoll.c --]
[-- Type: text/plain, Size: 718 bytes --]

From: Jesse Millan <jessem@cs.pdx.edu>



This patch eliminates the warning that is generated when passing a
reference of an uninitialized variable to a function where it possible
that the function will return without initializing that variable.

Signed-off-by: Jesse Millan <jessem@cs.pdx.edu>
Signed-off-by: Domen Puncer <domen@coderock.org>

---
 eventpoll.c |    3 +++
 1 files changed, 3 insertions(+)

Index: quilt/fs/eventpoll.c
===================================================================
--- quilt.orig/fs/eventpoll.c
+++ quilt/fs/eventpoll.c
@@ -748,6 +748,9 @@ eexit_3:
 eexit_2:
 	put_filp(file);
 eexit_1:
+	/* Reference went uninitialized. */
+	*efd = 0;
+	*efile = NULL;
 	return error;
 }
 

--

                 reply	other threads:[~2005-05-28 23:17 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050528231712.778427000@nd47.coderock.org \
    --to=domen@coderock.org \
    --cc=jessem@cs.pdx.edu \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@parcelfarce.linux.theplanet.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.