All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>,
	Markus Lidel <Markus.Lidel@shadowconnect.com>
Cc: linux-kernel@vger.kernel.org
Subject: [-mm patch] drivers/message/i2o/device.c: i2o_parm_issue has to be global
Date: Mon, 30 May 2005 21:50:37 +0200	[thread overview]
Message-ID: <20050530195037.GM10441@stusta.de> (raw)
In-Reply-To: <20050525134933.5c22234a.akpm@osdl.org>

On Wed, May 25, 2005 at 01:49:33PM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.12-rc4-mm2:
>...
> +i2o-first-code-cleanup-of-spare-warnings-and-unused.patch
>...
>  i2o driver updates
>...


This patch makes i2o_parm_issue static resulting in the following 
compile error in the static case (the modular case doesn't give a 
compile error, but EXPORT_SYMBOL'ing a static functions is equally 
wrong):

<--  snip  -->

...
  LD      .tmp_vmlinux1
drivers/built-in.o(.text+0x691d55): In function `i2o_cfg_parms':
: undefined reference to `i2o_parm_issue'
make: *** [.tmp_vmlinux1] Error 1

<--  snip  -->


This patch turns i2o_parm_issue back into a global function.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.12-rc5-mm1-full/drivers/message/i2o/device.c.old	2005-05-30 21:17:10.000000000 +0200
+++ linux-2.6.12-rc5-mm1-full/drivers/message/i2o/device.c	2005-05-30 21:17:21.000000000 +0200
@@ -443,8 +443,8 @@
  *	Note that the minimum sized reslist is 8 bytes and contains
  *	ResultCount, ErrorInfoSize, BlockStatus and BlockSize.
  */
-static int i2o_parm_issue(struct i2o_device *i2o_dev, int cmd, void *oplist,
-			  int oplen, void *reslist, int reslen)
+int i2o_parm_issue(struct i2o_device *i2o_dev, int cmd, void *oplist,
+		   int oplen, void *reslist, int reslen)
 {
 	struct i2o_message __iomem *msg;
 	u32 m;


  parent reply	other threads:[~2005-05-30 19:51 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-25 20:49 2.6.12-rc5-mm1 Andrew Morton
2005-05-25 21:37 ` 2.6.12-rc5-mm1 Alexandre Buisse
2005-05-25 21:51 ` 2.6.12-rc5-mm1 Brice Goglin
2005-05-25 21:58 ` 2.6.12-rc5-mm1 Brice Goglin
2005-05-26  5:29   ` 2.6.12-rc5-mm1 Yani Ioannou
2005-05-25 22:57 ` 2.6.12-rc5-mm1 Jesper Juhl
2005-05-26  1:17 ` 2.6.12-rc5-mm1 Matthew Dobson
2005-05-26  2:43 ` 2.6.12-rc5-mm1 Ed Tomlinson
2005-05-26  3:41   ` 2.6.12-rc5-mm1 Andrew Morton
2005-05-26  7:43     ` 2.6.12-rc5-mm1 J.A. Magallon
2005-05-26  7:58       ` 2.6.12-rc5-mm1 Andrew Morton
2005-05-26  7:58         ` 2.6.12-rc5-mm1 Andrew Morton
2005-05-26 13:54         ` 2.6.12-rc5-mm1 Rafael J. Wysocki
2005-05-26 20:45           ` 2.6.12-rc5-mm1 Andrew Morton
2005-05-26 20:45             ` 2.6.12-rc5-mm1 Andrew Morton
2005-05-26 21:04             ` 2.6.12-rc5-mm1 Lee Revell
2005-05-26 21:04               ` 2.6.12-rc5-mm1 Lee Revell
2005-05-26 21:07             ` 2.6.12-rc5-mm1 Chris Wright
2005-05-26 21:07               ` 2.6.12-rc5-mm1 Chris Wright
2005-05-27 10:29             ` 2.6.12-rc5-mm1 Rafael J. Wysocki
2005-05-27 10:29               ` 2.6.12-rc5-mm1 Rafael J. Wysocki
2005-05-27 17:38               ` 2.6.12-rc5-mm1 Chen, Kenneth W
2005-05-27 17:38                 ` 2.6.12-rc5-mm1 Chen, Kenneth W
2005-05-27 22:32                 ` 2.6.12-rc5-mm1 J.A. Magallon
2005-05-26 21:39         ` 2.6.12-rc5-mm1 J.A. Magallon
2005-05-26  7:44 ` 2.6.12-rc5-mm1 J.A. Magallon
2005-05-26  7:52   ` 2.6.12-rc5-mm1 Andrew Morton
2005-05-26  8:57 ` 2.6.12-rc5-mm1 Mikael Pettersson
2005-05-26 13:04   ` 2.6.12-rc5-mm1 Andrea Arcangeli
2005-05-26 19:15     ` 2.6.12-rc5-mm1 Mikael Pettersson
2005-05-26 22:22       ` 2.6.12-rc5-mm1 Andrea Arcangeli
2005-05-27  2:47         ` 2.6.12-rc5-mm1 Andrea Arcangeli
2005-05-27 21:13 ` 2.6.12-rc5-mm1 Arnd Bergmann
2005-05-28  7:07   ` 2.6.12-rc5-mm1 Christoph Hellwig
2005-06-29 13:42     ` 2.6.12-rc5-mm1 Arnd Bergmann
2005-06-29 16:22       ` Xtensa syscalls (Was: Re: 2.6.12-rc5-mm1) Christian Zankel
2005-06-29 16:29         ` Christoph Hellwig
2005-06-29 16:47         ` Andrew Morton
2005-06-29 19:11         ` Arnd Bergmann
2005-05-27 22:21 ` Kill signed chars !!! [was Re: 2.6.12-rc5-mm1] J.A. Magallon
2005-05-27 23:46   ` Jesper Juhl
2005-06-21 12:54   ` Kill signed chars !!! => PPC uses unsigned chars Willy Tarreau
2005-06-21 14:23     ` cutaway
2005-06-21 21:13       ` J.A. Magallon
2005-05-29 14:26 ` 2.6.12-rc5-mm1: fork connector doesn't compile with gcc 2.95 Adrian Bunk
2005-05-29 14:38 ` 2.6.12-rc5-mm1: drivers/char/tpm/ compile errors " Adrian Bunk
2005-05-29 14:38 ` 2.6.12-rc5-mm1: drivers/dlm/: compile error " Adrian Bunk
2005-05-29 14:43   ` Matthias-Christian Ott
2005-05-29 15:00     ` Adrian Bunk
2005-05-29 14:45 ` 2.6.12-rc5-mm1: drivers/media/dvb/dvb-usb/a800.c compile error Adrian Bunk
2005-05-30  8:29   ` Patrick Boettcher
2005-05-30  9:14     ` Johannes Stezenbach
2005-05-30  9:30       ` Patrick Boettcher
2005-05-29 15:12 ` 2.6.12-rc5-mm1: drivers/usb/atm/speedtch.c: gcc 2.95 " Adrian Bunk
2005-05-30  7:45   ` Duncan Sands
2005-05-30  8:04     ` Andrew Morton
2005-05-30  8:16       ` Duncan Sands
2005-05-30 13:52 ` 2.6.12-rc5-mm1 Stefano Rivoir
2005-05-30 19:50 ` Adrian Bunk [this message]
2005-05-31 12:00 ` [PATCH 2.6.12-rc5-mm1] m32r: Insert set_tsk_need_resched() to cpu_idle() (was Re: 2.6.12-rc5-mm1) Hirokazu Takata

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050530195037.GM10441@stusta.de \
    --to=bunk@stusta.de \
    --cc=Markus.Lidel@shadowconnect.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.