All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: "Michael S. Tsirkin" <mst@mellanox.co.il>
Cc: linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH] pci-sysfs: backport fix for 2.6.11.12
Date: Tue, 31 May 2005 12:23:49 -0700	[thread overview]
Message-ID: <20050531192349.GA21050@suse.de> (raw)
In-Reply-To: <20050531163619.GA6711@mellanox.co.il>

On Tue, May 31, 2005 at 07:36:19PM +0300, Michael S. Tsirkin wrote:
> Greg, before 2.6.12, pci_write_config in pci-sysfs.c was broken, causing
> incorrect data being written to the configuration register,
> which in the case of my userspace driver results in system failure.
> 
> This has been fixed in 2.6.12-rc5:
> 
> http://www.kernel.org/diff/diffview.cgi?file=%2Fpub%2Flinux%2Fkernel%2Fv2.6%2Ftesting%2Fpatch-2.6.12-rc5.bz2;z=2656
> 
> Would you please consider merging the fix for 2.6.11.12 as well?

Would you care to split out only the proper part for that fix?  There
are a few different patches in that link above.

> Alternatively (since there were multiple other changes in pci-sysfs.c), here's
> a small patch to fix just this issue.

I don't think this fixes the problem properly.  Can you verify it?
Also, this is only a 64bit issue, right?  What platform are you seeing
this on?

And, any patch that you want to propose for the -stable releases, needs
to be sent to the stable@kernel.org email alias.

thanks,

greg k-h

  reply	other threads:[~2005-05-31 19:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-31 16:36 [PATCH] pci-sysfs: backport fix for 2.6.11.12 Michael S. Tsirkin
2005-05-31 19:23 ` Greg KH [this message]
2005-05-31 20:57   ` Michael S. Tsirkin
2005-05-31 21:21     ` Greg KH
2005-05-31 21:25     ` Matthew Wilcox
2005-05-31 21:40       ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050531192349.GA21050@suse.de \
    --to=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=mst@mellanox.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.